linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Liu Bo <bo.li.liu@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 0/6] add sanity check for extent inline ref type
Date: Thu, 25 May 2017 18:26:25 -0600	[thread overview]
Message-ID: <20170526002631.8546-1-bo.li.liu@oracle.com> (raw)

An invalid extent inline ref type could be read from a btrfs image and
it ends up with a panic[1], this set is to deal with the insane value
gracefully in patch 1-2 and clean up BUG() in the code in patch 3-5.

Patch 6 adds scrub support to detect the corruption, so users can be
noticed when they do scrub on a regular basis.

I'm not sure in the real world what may result in this corruption, but
I've seen several reports on the ML about __btrfs_free_extent saying
something was missing (or simply wrong), while testing this set with
btrfs-corrupt-block, I found that switching ref type could end up that
situation as well, eg. a data extent's ref type
(BTRFS_EXTENT_DATA_REF_KEY) is switched to (BTRFS_TREE_BLOCK_REF_KEY).

Hopefully this can give people more sights next time when that
happens.

[1]:https://www.spinics.net/lists/linux-btrfs/msg65646.html

Liu Bo (6):
  Btrfs: add a helper to retrive extent inline ref type
  Btrfs: convert to use btrfs_get_extent_inline_ref_type
  Btrfs: remove BUG() in btrfs_extent_inline_ref_size
  Btrfs: remove BUG() in print_extent_item
  Btrfs: remove BUG() in add_data_reference
  Btrfs: add sanity check of extent item in scrub

 fs/btrfs/backref.c     |  9 +++++--
 fs/btrfs/ctree.h       |  5 +++-
 fs/btrfs/extent-tree.c | 68 ++++++++++++++++++++++++++++++++++++++++++++------
 fs/btrfs/print-tree.c  |  8 +++++-
 fs/btrfs/relocation.c  | 20 ++++++++++++---
 fs/btrfs/scrub.c       | 43 +++++++++++++++++++++++++++++++
 6 files changed, 139 insertions(+), 14 deletions(-)

-- 
2.9.4


             reply	other threads:[~2017-05-26  1:27 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-26  0:26 Liu Bo [this message]
2017-05-26  0:26 ` [PATCH 1/6] Btrfs: add a helper to retrive extent inline ref type Liu Bo
2017-05-26  7:09   ` Nikolay Borisov
2017-05-26 17:44     ` Jeff Mahoney
2017-05-26 18:13     ` David Sterba
2017-05-26 18:15       ` David Sterba
2017-05-26  0:26 ` [PATCH 2/6] Btrfs: convert to use btrfs_get_extent_inline_ref_type Liu Bo
2017-05-26  0:26 ` [PATCH 3/6] Btrfs: remove BUG() in btrfs_extent_inline_ref_size Liu Bo
2017-05-26  0:26 ` [PATCH 4/6] Btrfs: remove BUG() in print_extent_item Liu Bo
2017-05-26 18:18   ` David Sterba
2017-05-26 19:52     ` Liu Bo
2017-05-26  0:26 ` [PATCH 5/6] Btrfs: remove BUG() in add_data_reference Liu Bo
2017-05-26 18:20   ` David Sterba
2017-05-26 20:01     ` Liu Bo
2017-05-26  0:26 ` [PATCH 6/6] Btrfs: add sanity check of extent item in scrub Liu Bo
2017-05-26 18:33   ` David Sterba
2017-05-26 20:20     ` Liu Bo
2017-05-29  1:48       ` Qu Wenruo
2017-05-29 13:49         ` David Sterba
2017-05-30 14:05 ` [PATCH 0/6] add sanity check for extent inline ref type Ivan Sizov
2017-05-30 18:02   ` Liu Bo
2017-05-30 18:57     ` Ivan Sizov
2017-06-01 17:35   ` Liu Bo
2017-06-01 20:26     ` Ivan Sizov
2017-06-01 22:57       ` Liu Bo
2017-06-19  9:06         ` Ivan Sizov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170526002631.8546-1-bo.li.liu@oracle.com \
    --to=bo.li.liu@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).