From: Christoph Hellwig <hch@lst.de>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, dm-devel@redhat.com,
linux-btrfs@vger.kernel.org
Subject: [PATCH 02/13] scsi/osd: don't save block errors into req_results
Date: Fri, 26 May 2017 11:56:09 +0300 [thread overview]
Message-ID: <20170526085620.3113-3-hch@lst.de> (raw)
In-Reply-To: <20170526085620.3113-1-hch@lst.de>
We will only have sense data if the command exectured and got a SCSI
result, so this is pointless.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/scsi/osd/osd_initiator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c
index 8a1b94816419..14785177ce7b 100644
--- a/drivers/scsi/osd/osd_initiator.c
+++ b/drivers/scsi/osd/osd_initiator.c
@@ -477,7 +477,7 @@ static void _set_error_resid(struct osd_request *or, struct request *req,
int error)
{
or->async_error = error;
- or->req_errors = scsi_req(req)->result ? : error;
+ or->req_errors = scsi_req(req)->result;
or->sense_len = scsi_req(req)->sense_len;
if (or->sense_len)
memcpy(or->sense, scsi_req(req)->sense, or->sense_len);
--
2.11.0
next prev parent reply other threads:[~2017-05-26 8:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 8:56 dedicated error codes for the block layer V2 Christoph Hellwig
2017-05-26 8:56 ` [PATCH 01/13] nvme-lightnvm: use blk_execute_rq in nvme_nvm_submit_user_cmd Christoph Hellwig
2017-05-26 8:56 ` Christoph Hellwig [this message]
2017-05-26 20:24 ` [PATCH 02/13] scsi/osd: don't save block errors into req_results Martin K. Petersen
2017-05-28 9:49 ` Christoph Hellwig
2017-05-26 8:56 ` [PATCH 03/13] gfs2: remove the unused sd_log_error field Christoph Hellwig
2017-05-26 8:56 ` [PATCH 04/13] dm: fix REQ_RAHEAD handling Christoph Hellwig
2017-05-26 8:56 ` [PATCH 05/13] fs: remove the unused error argument to dio_end_io() Christoph Hellwig
2017-05-29 13:12 ` David Sterba
2017-05-26 8:56 ` [PATCH 06/13] fs: simplify dio_bio_complete Christoph Hellwig
2017-05-26 8:56 ` [PATCH 07/13] block_dev: propagate bio_iov_iter_get_pages error in __blkdev_direct_IO Christoph Hellwig
2017-05-26 9:12 ` Johannes Thumshirn
2017-05-28 9:49 ` Christoph Hellwig
2017-05-26 8:56 ` [PATCH 08/13] dm mpath: merge do_end_io_bio into multipath_end_io_bio Christoph Hellwig
2017-05-26 8:56 ` [PATCH 09/13] dm: don't return errnos from ->map Christoph Hellwig
2017-05-26 8:56 ` [PATCH 10/13] dm: change ->end_io calling convention Christoph Hellwig
2017-05-26 8:56 ` [PATCH 12/13] blk-mq: switch ->queue_rq return value to blk_status_t Christoph Hellwig
2017-05-29 13:16 ` dedicated error codes for the block layer V2 David Sterba
-- strict thread matches above, loose matches on Subject: below --
2017-06-03 7:37 dedicated error codes for the block layer V3 Christoph Hellwig
2017-06-03 7:37 ` [PATCH 02/13] scsi/osd: don't save block errors into req_results Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170526085620.3113-3-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).