From: Sargun Dhillon <sargun@sargun.me>
To: linux-btrfs@vger.kernel.org
Cc: quwenruo@cn.fujitsu.com, mkh@rqc.ru
Subject: [PATCH v2 3/4] btrfs: Warn the user when the legacy btrfs_qgroup_create API is used
Date: Fri, 26 May 2017 20:44:50 +0000 [thread overview]
Message-ID: <20170526204449.GA18209@ircssh-2.c.rugged-nimbus-611.internal> (raw)
In-Reply-To: <20170526204414.GA18176@ircssh-2.c.rugged-nimbus-611.internal>
This patch adds a warning to let the user know when the legacy
qgroup creation / removal API is in use. Eventually, we can
deprecate this API.
Signed-off-by: Sargun Dhillon <sargun@sargun.me>
---
fs/btrfs/ioctl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 78c8321..fba409f 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -5027,6 +5027,8 @@ static long btrfs_ioctl_qgroup_create(struct file *file, void __user *arg)
if (!capable(CAP_SYS_ADMIN))
return -EPERM;
+ pr_info_once("btrfs: Usage of deprecated btrfs_qgroup_create ioctl\n");
+
ret = mnt_want_write_file(file);
if (ret)
return ret;
--
2.9.3
next prev parent reply other threads:[~2017-05-26 20:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-26 20:44 [PATCH v2 0/4] Qgroup uapi improvements Sargun Dhillon
2017-05-26 20:44 ` [PATCH v2 1/4] btrfs: Fail on removing qgroup if del_qgroup_item fails Sargun Dhillon
2017-05-26 20:44 ` [PATCH v2 2/4] btrfs: Add new ioctl uapis for qgroup creation / removal Sargun Dhillon
2017-06-30 16:31 ` David Sterba
2017-05-26 20:44 ` Sargun Dhillon [this message]
2017-06-30 15:59 ` [PATCH v2 3/4] btrfs: Warn the user when the legacy btrfs_qgroup_create API is used David Sterba
2017-05-26 20:45 ` [PATCH v2 4/4] btrfs: Add qgroup_auto_cleanup mount flag to automatically cleanup qgroups Sargun Dhillon
2017-06-30 15:53 ` David Sterba
2017-06-23 17:05 ` [PATCH v2 0/4] Qgroup uapi improvements Sargun Dhillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170526204449.GA18209@ircssh-2.c.rugged-nimbus-611.internal \
--to=sargun@sargun.me \
--cc=linux-btrfs@vger.kernel.org \
--cc=mkh@rqc.ru \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).