From: Timofey Titovets <nefelim4ag@gmail.com>
To: linux-btrfs@vger.kernel.org
Cc: Timofey Titovets <nefelim4ag@gmail.com>
Subject: [PATCH 2/7] Btrfs: backref_comp decrease max compare count
Date: Wed, 7 Jun 2017 03:58:39 +0300 [thread overview]
Message-ID: <20170607005844.2078-3-nefelim4ag@gmail.com> (raw)
In-Reply-To: <20170607005844.2078-1-nefelim4ag@gmail.com>
In worst case code do 6 comparison,
just add some new checks to switch check branch faster
now in worst case code do 4 comparison
Signed-off-by: Timofey Titovets <nefelim4ag@gmail.com>
---
fs/btrfs/inode.c | 21 ++++++++++++---------
1 file changed, 12 insertions(+), 9 deletions(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 17cbe9306..fa024642a 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -2249,20 +2249,23 @@ struct new_sa_defrag_extent {
static int backref_comp(struct sa_defrag_extent_backref *b1,
struct sa_defrag_extent_backref *b2)
{
- if (b1->root_id < b2->root_id)
- return -1;
- else if (b1->root_id > b2->root_id)
+ if (b1->root_id != b2->root_id) {
+ if (b1->root_id < b2->root_id)
+ return -1;
return 1;
+ }
- if (b1->inum < b2->inum)
- return -1;
- else if (b1->inum > b2->inum)
+ if (b1->inum != b2->inum) {
+ if (b1->inum < b2->inum)
+ return -1;
return 1;
+ }
- if (b1->file_pos < b2->file_pos)
- return -1;
- else if (b1->file_pos > b2->file_pos)
+ if (b1->file_pos != b2->file_pos) {
+ if (b1->file_pos < b2->file_pos)
+ return -1;
return 1;
+ }
/*
* [------------------------------] ===> (a range of space)
--
2.13.0
next prev parent reply other threads:[~2017-06-07 1:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 0:58 [PATCH 0/7] Btrfs: if else cleanups Timofey Titovets
2017-06-07 0:58 ` [PATCH 1/7] Btrfs: __compare_inode_defrag decrease max compare count Timofey Titovets
2017-06-07 0:58 ` Timofey Titovets [this message]
2017-06-07 0:58 ` [PATCH 3/7] Btrfs: ref_node_cmp " Timofey Titovets
2017-06-07 0:58 ` [PATCH 4/7] Btrfs: ref_tree_add remove useless compare Timofey Titovets
2017-06-07 0:58 ` [PATCH 5/7] Btrfs: add_all_parents skip compare Timofey Titovets
2017-06-07 0:58 ` [PATCH 6/7] Btrfs: __tree_mod_log_insert decrease max compare count Timofey Titovets
2017-06-07 9:45 ` Filipe Manana
2017-06-07 11:01 ` Timofey Titovets
2017-06-13 14:24 ` David Sterba
2017-06-07 0:58 ` [PATCH 7/7] Btrfs: end_workqueue_bio use switch case instead of else if Timofey Titovets
2017-06-07 22:48 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170607005844.2078-3-nefelim4ag@gmail.com \
--to=nefelim4ag@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).