From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:53835 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750868AbdFLMpe (ORCPT ); Mon, 12 Jun 2017 08:45:34 -0400 Date: Mon, 12 Jun 2017 05:44:01 -0700 From: Christoph Hellwig To: Jeff Layton Cc: Andrew Morton , Al Viro , Jan Kara , tytso@mit.edu, axboe@kernel.dk, mawilcox@microsoft.com, ross.zwisler@linux.intel.com, corbet@lwn.net, Chris Mason , Josef Bacik , David Sterba , "Darrick J . Wong" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH v6 14/20] dax: set errors in mapping when writeback fails Message-ID: <20170612124401.GB18360@infradead.org> References: <20170612122316.13244-1-jlayton@redhat.com> <20170612122316.13244-19-jlayton@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170612122316.13244-19-jlayton@redhat.com> Sender: linux-btrfs-owner@vger.kernel.org List-ID: On Mon, Jun 12, 2017 at 08:23:10AM -0400, Jeff Layton wrote: > For now, only do this when the FS_WB_ERRSEQ flag is set. The > AS_EIO/AS_ENOSPC flags are not currently cleared in the older code when > writeback initiation fails, only when we discover an error after waiting > on writeback to complete, so we only want to do this with errseq_t based > error handling to prevent seeing duplicate errors on fsync. Please make sure this doens't stay conditional by the end of the series. We only have three file systems using dax, and a series should be able to make them agree on a single interface.