* [PATCH] btrfs: use new block error code
@ 2017-06-19 10:55 Dan Carpenter
2017-06-20 9:11 ` Christoph Hellwig
2017-06-21 13:17 ` David Sterba
0 siblings, 2 replies; 4+ messages in thread
From: Dan Carpenter @ 2017-06-19 10:55 UTC (permalink / raw)
To: Chris Mason, Christoph Hellwig
Cc: Josef Bacik, David Sterba, linux-btrfs, linux-block, Jens Axboe,
kernel-janitors
This function is supposed to return blk_status_t error codes now but
there was a stray -ENOMEM left behind.
Fixes: 4e4cbee93d56 ("block: switch bios to blk_status_t")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c
index e536e98fe351..2c0b7b57fcd5 100644
--- a/fs/btrfs/compression.c
+++ b/fs/btrfs/compression.c
@@ -584,7 +584,7 @@ blk_status_t btrfs_submit_compressed_read(struct inode *inode, struct bio *bio,
__GFP_HIGHMEM);
if (!cb->compressed_pages[pg_index]) {
faili = pg_index - 1;
- ret = -ENOMEM;
+ ret = BLK_STS_RESOURCE;
goto fail2;
}
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] btrfs: use new block error code
2017-06-19 10:55 [PATCH] btrfs: use new block error code Dan Carpenter
@ 2017-06-20 9:11 ` Christoph Hellwig
2017-06-21 13:17 ` David Sterba
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2017-06-20 9:11 UTC (permalink / raw)
To: Dan Carpenter
Cc: Chris Mason, Christoph Hellwig, Josef Bacik, David Sterba,
linux-btrfs, linux-block, Jens Axboe, kernel-janitors
On Mon, Jun 19, 2017 at 01:55:37PM +0300, Dan Carpenter wrote:
> This function is supposed to return blk_status_t error codes now but
> there was a stray -ENOMEM left behind.
>
> Fixes: 4e4cbee93d56 ("block: switch bios to blk_status_t")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Looks fine,
Acked-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] btrfs: use new block error code
2017-06-19 10:55 [PATCH] btrfs: use new block error code Dan Carpenter
2017-06-20 9:11 ` Christoph Hellwig
@ 2017-06-21 13:17 ` David Sterba
2017-06-21 13:48 ` Jens Axboe
1 sibling, 1 reply; 4+ messages in thread
From: David Sterba @ 2017-06-21 13:17 UTC (permalink / raw)
To: Dan Carpenter
Cc: Chris Mason, Christoph Hellwig, Josef Bacik, David Sterba,
linux-btrfs, linux-block, Jens Axboe, kernel-janitors
On Mon, Jun 19, 2017 at 01:55:37PM +0300, Dan Carpenter wrote:
> This function is supposed to return blk_status_t error codes now but
> there was a stray -ENOMEM left behind.
>
> Fixes: 4e4cbee93d56 ("block: switch bios to blk_status_t")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: David Sterba <dsterba@suse.com>
The patch depends on the blk_status_t patchset, so I expect that it's
going to be merged to that.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] btrfs: use new block error code
2017-06-21 13:17 ` David Sterba
@ 2017-06-21 13:48 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2017-06-21 13:48 UTC (permalink / raw)
To: dsterba, Dan Carpenter, Chris Mason, Christoph Hellwig,
Josef Bacik, David Sterba, linux-btrfs, linux-block,
kernel-janitors
On 06/21/2017 07:17 AM, David Sterba wrote:
> On Mon, Jun 19, 2017 at 01:55:37PM +0300, Dan Carpenter wrote:
>> This function is supposed to return blk_status_t error codes now but
>> there was a stray -ENOMEM left behind.
>>
>> Fixes: 4e4cbee93d56 ("block: switch bios to blk_status_t")
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Acked-by: David Sterba <dsterba@suse.com>
>
> The patch depends on the blk_status_t patchset, so I expect that it's
> going to be merged to that.
Added, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-06-21 13:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-19 10:55 [PATCH] btrfs: use new block error code Dan Carpenter
2017-06-20 9:11 ` Christoph Hellwig
2017-06-21 13:17 ` David Sterba
2017-06-21 13:48 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).