* [PATCH] btrfs: add cond_resched to btrfs_qgroup_trace_leaf_items
@ 2017-06-20 12:15 jeffm
2017-06-21 13:47 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: jeffm @ 2017-06-20 12:15 UTC (permalink / raw)
To: linux-btrfs; +Cc: Jeff Mahoney
From: Jeff Mahoney <jeffm@suse.com>
On an uncontended system, we can end up hitting soft lockups while
doing replace_path. At the core, and frequently called is
btrfs_qgroup_trace_leaf_items, so it makes sense to add a cond_resched
there.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
fs/btrfs/qgroup.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index deffbeb74a0b..7a3cfa22e178 100644
--- a/fs/btrfs/qgroup.c
+++ b/fs/btrfs/qgroup.c
@@ -1559,6 +1559,7 @@ int btrfs_qgroup_trace_leaf_items(struct btrfs_trans_handle *trans,
if (ret)
return ret;
}
+ cond_resched();
return 0;
}
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] btrfs: add cond_resched to btrfs_qgroup_trace_leaf_items
2017-06-20 12:15 [PATCH] btrfs: add cond_resched to btrfs_qgroup_trace_leaf_items jeffm
@ 2017-06-21 13:47 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2017-06-21 13:47 UTC (permalink / raw)
To: jeffm; +Cc: linux-btrfs
On Tue, Jun 20, 2017 at 08:15:26AM -0400, jeffm@suse.com wrote:
> From: Jeff Mahoney <jeffm@suse.com>
>
> On an uncontended system, we can end up hitting soft lockups while
> doing replace_path. At the core, and frequently called is
> btrfs_qgroup_trace_leaf_items, so it makes sense to add a cond_resched
> there.
>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-21 13:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-06-20 12:15 [PATCH] btrfs: add cond_resched to btrfs_qgroup_trace_leaf_items jeffm
2017-06-21 13:47 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).