From: Christoph Hellwig <hch@lst.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: David Sterba <dsterba@suse.com>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Btrfs for 4.13
Date: Thu, 6 Jul 2017 03:50:52 +0200 [thread overview]
Message-ID: <20170706015052.GA14129@lst.de> (raw)
In-Reply-To: <CA+55aFwFWYtivrNgayV2nhpjv780eWMGRyJA=YwRia6-zvZb_A@mail.gmail.com>
On Wed, Jul 05, 2017 at 04:45:49PM -0700, Linus Torvalds wrote:
> Ouch, yeah, that was annoying. And yes, I ended up with several
> whitespace differences but other than that it looks the same. Oh well.
>
> Jens, Christoph, let's not do that stupid thing with status-vs-error
> ever again, ok?
It should be done now :)
Back to serious - this work had to be done as we could not communicate
errors properly in the block layer with people inventing their own
codes all the time. That being said, in retrospective I should have
tried a gradual approach that first defines the new code to the old
errors and left the fields in place. I opted for the hard break to
make sure we can catch matching conversions by the compiler as very
few people run sparse for the __bitwise annotations, and some of
the drivers create so many sparse warnings that they would be lost
anyway.
But I've learned and will try to make something like this gradual
if it comes up, and hope we won't have to do something like it again
at all.
prev parent reply other threads:[~2017-07-06 1:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 15:19 [GIT PULL] Btrfs for 4.13 David Sterba
2017-07-05 23:45 ` Linus Torvalds
2017-07-06 1:50 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170706015052.GA14129@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).