linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc MERLIN <marc@merlins.org>
To: Omar Sandoval <osandov@osandov.com>
Cc: linux-btrfs@vger.kernel.org, pwnall@chromium.org
Subject: Re: Leveldb in google-chrome incompatible with btrfs?
Date: Thu, 6 Jul 2017 16:31:52 -0700	[thread overview]
Message-ID: <20170706233152.GI30689@merlins.org> (raw)
In-Reply-To: <20170706230141.GA22242@vader.DHCP.thefacebook.com>

On Thu, Jul 06, 2017 at 04:01:41PM -0700, Omar Sandoval wrote:
> What doesn't add up about your bug report is that your CURRENT points to
> a MANIFEST-010814 way behind all of the other files in that directory,
> which are numbered 022745+. If there were a bug here, I'd expect the
> stale MANIFEST file would be one older than the new one. The filenames
> seem to be allocated sequentially, so that old MANIFEST file CURRENT
> refers to must be really old, which doesn't make sense. I don't see how
> Btrfs would screw that up :) I'd be interested to see if you can make
> the same condition trigger again.
> 

First, thanks for looking at it.

Second, you are right on the numbers being so far apart that something was
wrong. I checked my snapshots, and I've been carrying that MANIFEST-010814
for a long time.
In other words, it's a old stale manifest that never got deleted.

The new real old one apparently got deleted, the new one was created but
didn't make it to disk, but the pointer in CURRENT did get repointed to the
new one that never made it to actual disk.

So I think what happened is something like this:
MANIFEST-new got created
echo MANIFEST-new > CURRENT
MANIFEST-old got deleted
system crashed

MANIFEST-old was indeed deleted, and MANIFEST-new never made it to disk.

Does that sound more plausible?

As for redoing this at will, apparently I may have been hit by the skylake
hyperthreading CPU bug that I just installed a microcode update for, which
was causing random crashes, which hopefully are now solved.
I can't say if those in turn messed with btrfs writing data, but I'd rather
not recreate this since it's my real filesystem I care about and don't want
to corrupt on purpose :)
That said, the google-chrome on my previous haswell CPU also had routine
problems when restarting chrome, although at this point I don't know if they
were due to leveldb or sqlite or something else.
I'm just mentioning this to say that I'm pretty sure that the haswell HT bug
isn't the sole culprit of this problem, likely just the trigger of some of
my crashes.

Hope this helps
Marc
-- 
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
                                      .... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/  

  reply	other threads:[~2017-07-06 23:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-06 15:00 Leveldb in google-chrome incompatible with btrfs? Marc MERLIN
2017-07-06 21:13 ` Omar Sandoval
2017-07-06 21:24   ` Marc MERLIN
2017-07-06 23:01     ` Omar Sandoval
2017-07-06 23:31       ` Marc MERLIN [this message]
2017-07-06 23:44         ` Omar Sandoval
2017-07-06 23:59           ` Marc MERLIN
2017-07-07  5:46             ` Omar Sandoval
2017-07-07 15:05               ` Cerem Cem ASLAN
2017-07-07 16:50             ` Marc MERLIN
2017-07-12  8:14               ` Cerem Cem ASLAN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170706233152.GI30689@merlins.org \
    --to=marc@merlins.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=osandov@osandov.com \
    --cc=pwnall@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).