From: Edmund Nadolski <enadolski@suse.com>
To: enadolski@suse.com, dsterba@suse.cz, jeffm@suse.com,
linux-btrfs@vger.kernel.org, lufq.fnst@cn.fujitsu.com
Subject: [PATCH v3 00/13] use rbtrees for preliminary backrefs
Date: Wed, 12 Jul 2017 16:20:05 -0600 [thread overview]
Message-ID: <20170712222011.26705-1-enadolski@suse.com> (raw)
This patch series attempts to improve the performance of backref
searches by changing the prelim_refs implementation to use
rbtrees instead of lists. This also aims to reduce the soft
lockup occurences that can result when a backref search consumes
too much cpu time.
Test runs of btrfs/130 show an improvement in the overall
run time of the test (shown below in seconds) as a function of
the number of extents:
nr_extents: 256 512 640 1024 2048
------------+-------+-----+-------+-------+------
unpatched: 20 186 375 2204 40419
patched: 12 93 203 1060 22007
(Note, the current default value for nr_extents in btrfs/130 is
4096, which takes a very long time to complete.)
Changes for v3:
Patch 08/13:
- Update changelog and comments for third rbtree.
- Fixed issue in resolve_indirect_refs() which prevented
module load when sanity checking was enabled.
Patch 10/13:
- Fix TP_printk_btrfs format string per coding standards.
Changes for v2:
Patch 06/13:
- Added changelog description.
Patch 07/13:
- Updated changelog description.
- Removed 'TODO' comment.
Patch 08/13:
- Added code for proper iteration of missing keys. This adds
a third rbtree (.indirect_missing_keys in struct preftrees)
plus the requisite code in add_prelim_ref(), add_missing_keys(),
resolve_indirect_refs(), and find_parent_nodes().
- Rename release_pref() to free_pref().
- Replace WARN() with BUG_ON().
- Remove 'TODO' comments and the unused 'merge_mode' enum.
The other patches have no functional changes. Some have diff
context changes due to the above modifications.
Edmund Nadolski (6):
btrfs: btrfs_check_shared should manage its own transaction
btrfs: remove ref_tree implementation from backref.c
btrfs: convert prelimary reference tracking to use rbtrees
btrfs: add cond_resched() calls when resolving backrefs
btrfs: allow backref search checks for shared extents
btrfs: clean up extraneous computations in add_delayed_refs
Jeff Mahoney (7):
btrfs: struct-funcs, constify readers
btrfs: constify tracepoint arguments
btrfs: backref, constify some arguments
btrfs: backref, add unode_aux_to_inode_list helper
btrfs: backref, cleanup __ namespace abuse
btrfs: add a node counter to each of the rbtrees
btrfs: backref, add tracepoints for prelim_ref insertion and merging
fs/btrfs/async-thread.c | 6 +-
fs/btrfs/async-thread.h | 6 +-
fs/btrfs/backref.c | 1072 ++++++++++++++++++------------------------
fs/btrfs/backref.h | 16 +-
fs/btrfs/btrfs_inode.h | 4 +-
fs/btrfs/ctree.h | 128 ++---
fs/btrfs/extent_io.c | 46 +-
fs/btrfs/extent_io.h | 19 +-
fs/btrfs/struct-funcs.c | 9 +-
fs/btrfs/super.c | 1 +
include/trace/events/btrfs.h | 300 +++++++-----
11 files changed, 772 insertions(+), 835 deletions(-)
--
2.10.2
next reply other threads:[~2017-07-12 22:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 22:20 Edmund Nadolski [this message]
2017-07-12 22:20 ` [PATCH v3 08/13] btrfs: convert prelimary reference tracking to use rbtrees Edmund Nadolski
2017-07-28 18:25 ` Liu Bo
2017-07-12 22:20 ` [PATCH v3 09/13] btrfs: add a node counter to each of the rbtrees Edmund Nadolski
2017-07-13 0:51 ` David Sterba
2017-07-12 22:20 ` [PATCH v3 10/13] btrfs: backref, add tracepoints for prelim_ref insertion and merging Edmund Nadolski
2017-07-13 0:18 ` David Sterba
2017-07-12 22:20 ` [PATCH v3 11/13] btrfs: add cond_resched() calls when resolving backrefs Edmund Nadolski
2017-07-13 0:08 ` David Sterba
2017-07-12 22:20 ` [PATCH v3 12/13] btrfs: allow backref search checks for shared extents Edmund Nadolski
2017-07-28 18:41 ` Liu Bo
2017-07-12 22:20 ` [PATCH v3 13/13] btrfs: clean up extraneous computations in add_delayed_refs Edmund Nadolski
2017-07-13 0:08 ` David Sterba
2017-07-28 14:54 ` [PATCH v3 00/13] use rbtrees for preliminary backrefs David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170712222011.26705-1-enadolski@suse.com \
--to=enadolski@suse.com \
--cc=dsterba@suse.cz \
--cc=jeffm@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=lufq.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).