Re: [PATCH] Btrfs: fix unexpected return value of bio_readpage_error

[Liu Bo <bo.li.liu@oracle.com>]

On Fri, Jul 14, 2017 at 02:32:09PM +0200, David Sterba wrote:
> On Thu, Jul 13, 2017 at 03:00:50PM -0700, Liu Bo wrote:
> > With blk_status_t, in bio_readpage_error() may return 1 as now
> > ->submit_bio_hook() may not set %ret if it runs without problem.
> 
> Huh, that is pretty subtle, good catch. Also it's good the patch can be
> applied independent of the blk_status_t changes, so I don't need to do 2
> branches and pull requests.
>

Thanks to the ASSERT(ret == -EIO) in end_bio_extent_readpage() ;)

thanks,
-liubo

> > This fixes that unexpected return value by changing
> > btrfs_check_repairable() to return a bool instead of updating %ret.
> > 
> > Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
> 
> Reviewed-by: David Sterba <dsterba@suse.com>