From: Gu Jinxiang <gujx@cn.fujitsu.com>
To: <linux-btrfs@vger.kernel.org>
Cc: Qu Wenruo <quwenruo@cn.fujitsu.com>
Subject: [PATCH v5 09/15] btrfs-progs: scrub: Introduce function to verify parities
Date: Sat, 15 Jul 2017 17:10:47 +0800 [thread overview]
Message-ID: <20170715091053.19725-9-gujx@cn.fujitsu.com> (raw)
In-Reply-To: <20170715091053.19725-1-gujx@cn.fujitsu.com>
From: Qu Wenruo <quwenruo@cn.fujitsu.com>
Introduce new function, verify_parities(), to check whether parities match
with full stripe, whose data stripes match with their csum.
Caller should fill the scrub_full_stripe structure properly before
calling this function.
Signed-off-by: Qu Wenruo <quwenruo@cn.fujitsu.com>
Signed-off-by: Gu Jinxiang <gujx@cn.fujitsu.com>
---
scrub.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 69 insertions(+)
diff --git a/scrub.c b/scrub.c
index b544587..33d5ce2 100644
--- a/scrub.c
+++ b/scrub.c
@@ -24,6 +24,7 @@
#include "disk-io.h"
#include "utils.h"
#include "kernel-lib/bitops.h"
+#include "kernel-lib/raid56.h"
/*
* For parity based profile (RAID56)
@@ -754,3 +755,71 @@ out:
btrfs_free_path(path);
return ret;
}
+
+/*
+ * Verify parities for RAID56
+ * Caller must fill @fstripe before calling this function
+ *
+ * Return 0 for parities matches.
+ * Return >0 for P or Q mismatch
+ * Return <0 for fatal error
+ */
+static int verify_parities(struct btrfs_fs_info *fs_info,
+ struct btrfs_scrub_progress *scrub_ctx,
+ struct scrub_full_stripe *fstripe)
+{
+ void **ptrs;
+ void *ondisk_p = NULL;
+ void *ondisk_q = NULL;
+ void *buf_p;
+ void *buf_q;
+ int nr_stripes = fstripe->nr_stripes;
+ int stripe_len = BTRFS_STRIPE_LEN;
+ int i;
+ int ret = 0;
+
+ ptrs = malloc(sizeof(void *) * fstripe->nr_stripes);
+ buf_p = malloc(fstripe->stripe_len);
+ buf_q = malloc(fstripe->stripe_len);
+ if (!ptrs || !buf_p || !buf_q) {
+ ret = -ENOMEM;
+ goto out;
+ }
+
+ for (i = 0; i < fstripe->nr_stripes; i++) {
+ struct scrub_stripe *stripe = &fstripe->stripes[i];
+
+ if (stripe->logical == BTRFS_RAID5_P_STRIPE) {
+ ondisk_p = stripe->data;
+ ptrs[i] = buf_p;
+ continue;
+ } else if (stripe->logical == BTRFS_RAID6_Q_STRIPE) {
+ ondisk_q = stripe->data;
+ ptrs[i] = buf_q;
+ continue;
+ } else {
+ ptrs[i] = stripe->data;
+ continue;
+ }
+ }
+ /* RAID6 */
+ if (ondisk_q) {
+ raid6_gen_syndrome(nr_stripes, stripe_len, ptrs);
+
+ if (memcmp(ondisk_q, ptrs[nr_stripes - 1], stripe_len) != 0 ||
+ memcmp(ondisk_p, ptrs[nr_stripes - 2], stripe_len))
+ ret = 1;
+ } else {
+ ret = raid5_gen_result(nr_stripes, stripe_len, nr_stripes - 1,
+ ptrs);
+ if (ret < 0)
+ goto out;
+ if (memcmp(ondisk_p, ptrs[nr_stripes - 1], stripe_len) != 0)
+ ret = 1;
+ }
+out:
+ free(buf_p);
+ free(buf_q);
+ free(ptrs);
+ return ret;
+}
--
2.9.4
next prev parent reply other threads:[~2017-07-15 9:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-15 9:10 [PATCH v5 01/15] btrfs-progs: Introduce new btrfs_map_block function which returns more unified result Gu Jinxiang
2017-07-15 9:10 ` [PATCH v5 02/15] btrfs-progs: Allow __btrfs_map_block_v2 to remove unrelated stripes Gu Jinxiang
2017-07-15 9:10 ` [PATCH v5 03/15] btrfs-progs: csum: Introduce function to read out data csums Gu Jinxiang
2017-07-15 9:10 ` [PATCH v5 04/15] btrfs-progs: scrub: Introduce structures to support offline scrub for RAID56 Gu Jinxiang
2017-07-15 9:10 ` [PATCH v5 05/15] btrfs-progs: scrub: Introduce functions to scrub mirror based tree block Gu Jinxiang
2017-07-15 9:10 ` [PATCH v5 06/15] btrfs-progs: scrub: Introduce functions to scrub mirror based data blocks Gu Jinxiang
2017-07-15 9:10 ` [PATCH v5 07/15] btrfs-progs: scrub: Introduce function to scrub one mirror-based extent Gu Jinxiang
2017-07-15 9:10 ` [PATCH v5 08/15] btrfs-progs: scrub: Introduce function to scrub one data stripe Gu Jinxiang
2017-07-15 9:10 ` Gu Jinxiang [this message]
2017-07-15 9:10 ` [PATCH v5 10/15] btrfs-progs: extent-tree: Introduce function to check if there is any extent in given range Gu Jinxiang
2017-07-15 9:10 ` [PATCH v5 11/15] btrfs-progs: scrub: Introduce function to recover data parity Gu Jinxiang
2017-07-15 9:10 ` [PATCH v5 12/15] btrfs-progs: scrub: Introduce helper to write a full stripe Gu Jinxiang
2017-07-15 9:10 ` [PATCH v5 13/15] btrfs-progs: scrub: Introduce a function to scrub one " Gu Jinxiang
2017-07-15 9:10 ` [PATCH v5 14/15] btrfs-progs: scrub: Introduce function to check a whole block group Gu Jinxiang
2017-07-15 9:10 ` [PATCH v5 15/15] btrfs-progs: scrub: Introduce offline scrub function Gu Jinxiang
2017-07-15 9:20 ` [PATCH v5 01/15] btrfs-progs: Introduce new btrfs_map_block function which returns more unified result Qu Wenruo
2017-07-18 6:33 ` [PATCH 00/15] Btrfs-progs offline scrub Gu Jinxiang
2017-07-19 16:45 ` Marco Lorenzo Crociani
2017-07-20 3:39 ` Qu Wenruo
2017-07-20 8:55 ` Marco Lorenzo Crociani
2017-07-20 9:10 ` Qu Wenruo
2017-07-20 9:17 ` Qu Wenruo
2017-07-20 9:40 ` Marco Lorenzo Crociani
2017-07-20 9:51 ` Qu Wenruo
2017-08-22 9:45 ` Gu, Jinxiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170715091053.19725-9-gujx@cn.fujitsu.com \
--to=gujx@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).