From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Adam Buchbinder <abuchbinder@google.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: Use '-t btrfs' mount option in tests.
Date: Thu, 20 Jul 2017 17:42:46 +0200 [thread overview]
Message-ID: <20170720154246.GF2866@suse.cz> (raw)
In-Reply-To: <70c530f5-24fa-c2ff-6aa1-a3f9e7963e47@gmx.com>
On Thu, Jul 20, 2017 at 05:40:00PM +0800, Qu Wenruo wrote:
>
>
> On 2017年07月13日 05:52, David Sterba wrote:
> > On Wed, Jul 12, 2017 at 01:05:22PM -0700, Adam Buchbinder wrote:
> >> Without it, mount (at least from util-linux 2.20.1) tries (and
> >> fails) to mount some filesystems as NTFS.
> >>
> >> Signed-off-by: Adam Buchbinder <abuchbinder@google.com>
> >
> > Applied, thanks.
>
> This patch will break convert self test.
>
> Convert test will try to mount ext* filesystem and re-check its content.
Right. I'd like to keep -t btrfs everywhere it applies, so I'll add
another helper that will be used in the convert tests and seems the
convert test helpers will need to be enhanced with extra parameter of
the converted fs. Which is sounds like a good idea anyway.
next prev parent reply other threads:[~2017-07-20 15:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 20:05 [PATCH] btrfs-progs: Use '-t btrfs' mount option in tests Adam Buchbinder
2017-07-12 21:52 ` David Sterba
2017-07-20 9:40 ` Qu Wenruo
2017-07-20 15:42 ` David Sterba [this message]
2017-07-21 12:36 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720154246.GF2866@suse.cz \
--to=dsterba@suse.cz \
--cc=abuchbinder@google.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).