From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>,
Adam Buchbinder <abuchbinder@google.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: Use '-t btrfs' mount option in tests.
Date: Fri, 21 Jul 2017 14:36:40 +0200 [thread overview]
Message-ID: <20170721123640.GG2866@suse.cz> (raw)
In-Reply-To: <20170720154246.GF2866@suse.cz>
On Thu, Jul 20, 2017 at 05:42:46PM +0200, David Sterba wrote:
> On Thu, Jul 20, 2017 at 05:40:00PM +0800, Qu Wenruo wrote:
> >
> >
> > On 2017年07月13日 05:52, David Sterba wrote:
> > > On Wed, Jul 12, 2017 at 01:05:22PM -0700, Adam Buchbinder wrote:
> > >> Without it, mount (at least from util-linux 2.20.1) tries (and
> > >> fails) to mount some filesystems as NTFS.
> > >>
> > >> Signed-off-by: Adam Buchbinder <abuchbinder@google.com>
> > >
> > > Applied, thanks.
> >
> > This patch will break convert self test.
> >
> > Convert test will try to mount ext* filesystem and re-check its content.
>
> Right. I'd like to keep -t btrfs everywhere it applies, so I'll add
> another helper that will be used in the convert tests and seems the
> convert test helpers will need to be enhanced with extra parameter of
> the converted fs. Which is sounds like a good idea anyway.
With
https://github.com/kdave/btrfs-progs/commit/18b519e694a6ef559d85072f86898ab5a61f6a05
https://github.com/kdave/btrfs-progs/commit/46809a7287eb41ff2fdb83f742bd5250b820145a
the testsuite now passes.
prev parent reply other threads:[~2017-07-21 12:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 20:05 [PATCH] btrfs-progs: Use '-t btrfs' mount option in tests Adam Buchbinder
2017-07-12 21:52 ` David Sterba
2017-07-20 9:40 ` Qu Wenruo
2017-07-20 15:42 ` David Sterba
2017-07-21 12:36 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170721123640.GG2866@suse.cz \
--to=dsterba@suse.cz \
--cc=abuchbinder@google.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).