From: Liu Bo <bo.li.liu@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v2 0/7] add sanity check for extent inline ref type
Date: Mon, 7 Aug 2017 15:55:24 -0600 [thread overview]
Message-ID: <20170807215531.12423-1-bo.li.liu@oracle.com> (raw)
An invalid extent inline ref type could be read from a btrfs image and
it ends up with a panic[1], this set is to deal with the insane value
gracefully in patch 1-2 and clean up BUG() in the code in patch 3-6.
Patch 7 adds one more check to see if the ref is a valid shared one.
I'm not sure in the real world what may result in this corruption, but
I've seen several reports on the ML about __btrfs_free_extent saying
something was missing (or simply wrong), while testing this set with
btrfs-corrupt-block, I found that switching ref type could end up that
situation as well, eg. a data extent's ref type
(BTRFS_EXTENT_DATA_REF_KEY) is switched to (BTRFS_TREE_BLOCK_REF_KEY).
Hopefully this can give people more sights next time when that
happens.
[1]:https://www.spinics.net/lists/linux-btrfs/msg65646.html
v2:
- add enum type and return BTRFS_REF_TYPE_INVALID instead of -EINVAL.
- remove one more BUG_ON which is in __add_tree_block.
- add validation check for shared refs.
- improve btrfs_print_leaf to show which refs has something wrong.
Liu Bo (7):
Btrfs: add a helper to retrive extent inline ref type
Btrfs: convert to use btrfs_get_extent_inline_ref_type
Btrfs: remove BUG() in btrfs_extent_inline_ref_size
Btrfs: remove BUG() in print_extent_item
Btrfs: remove BUG() in add_data_reference
Btrfs: remove BUG_ON in __add_tree_block
Btrfs: add one more sanity check for shared ref type
fs/btrfs/backref.c | 11 ++++--
fs/btrfs/ctree.h | 12 ++++++-
fs/btrfs/extent-tree.c | 93 ++++++++++++++++++++++++++++++++++++++++++++++----
fs/btrfs/print-tree.c | 28 ++++++++++++---
fs/btrfs/relocation.c | 29 +++++++++++++---
5 files changed, 155 insertions(+), 18 deletions(-)
--
2.9.4
next reply other threads:[~2017-08-07 22:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 21:55 Liu Bo [this message]
2017-08-07 21:55 ` [PATCH v2 1/7] Btrfs: add a helper to retrive extent inline ref type Liu Bo
2017-08-07 21:55 ` [PATCH v2 2/7] Btrfs: convert to use btrfs_get_extent_inline_ref_type Liu Bo
2017-08-07 21:55 ` [PATCH v2 3/7] Btrfs: remove BUG() in btrfs_extent_inline_ref_size Liu Bo
2017-08-07 21:55 ` [PATCH v2 4/7] Btrfs: remove BUG() in print_extent_item Liu Bo
2017-08-07 21:55 ` [PATCH v2 5/7] Btrfs: remove BUG() in add_data_reference Liu Bo
2017-08-07 21:55 ` [PATCH v2 6/7] Btrfs: remove BUG_ON in __add_tree_block Liu Bo
2017-08-07 21:55 ` [PATCH v2 7/7] Btrfs: add one more sanity check for shared ref type Liu Bo
2017-08-16 14:53 ` [PATCH v2 0/7] add sanity check for extent inline " David Sterba
2017-08-16 16:04 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170807215531.12423-1-bo.li.liu@oracle.com \
--to=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).