[RESEND PATCH] btrfs-progs: Specify C standard to gnu90 explicitly

[RESEND PATCH] btrfs-progs: Specify C standard to gnu90 explicitly

[Qu Wenruo]

Different C compilers have different default language standard.
This sometimes causes problem on different system.

For distribution like CentOS/RHEL7, its gcc is still 4.8 and will report
error for c90 style declaration, while most developers are using newer
gcc which will just ignore it.
This makes us hard to detect such language standard problem.

This patch will specify standard to gnu90 explicitly to avoid such problem.
Gnu90 is a good mix of c90 while provide a lot of useful gnu extension,
and is supported by all modern gcc and clang.

Reported-by: Marco Lorenzo Crociani <marcoc@prismatelecomtesting.com>
Signed-off-by: Qu Wenruo <quwenruo.btrfs@gmx.com>
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index 81598df1..cb1b3c5f 100644
--- a/Makefile
+++ b/Makefile
@@ -58,6 +58,7 @@ TOPDIR := $(shell pwd)
 
 # Common build flags
 CFLAGS = $(SUBST_CFLAGS) \
+	 -std=gnu90 \
 	 -include config.h \
 	 -DBTRFS_FLAT_INCLUDES \
 	 -D_XOPEN_SOURCE=700  \
-- 
2.13.2

Re: [RESEND PATCH] btrfs-progs: Specify C standard to gnu90 explicitly

[David Sterba]

On Tue, Aug 15, 2017 at 09:17:12AM +0900, Qu Wenruo wrote:
> Different C compilers have different default language standard.
> This sometimes causes problem on different system.
> 
> For distribution like CentOS/RHEL7, its gcc is still 4.8 and will report
> error for c90 style declaration, while most developers are using newer
> gcc which will just ignore it.
> This makes us hard to detect such language standard problem.
> 
> This patch will specify standard to gnu90 explicitly to avoid such problem.
> Gnu90 is a good mix of c90 while provide a lot of useful gnu extension,
> and is supported by all modern gcc and clang.
> 
> Reported-by: Marco Lorenzo Crociani <marcoc@prismatelecomtesting.com>
> Signed-off-by: Qu Wenruo <quwenruo.btrfs@gmx.com>

Applied, thanks.