public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Hallo32 <Hallo32@gmx.net>
Cc: Qu Wenruo <quwenruo.btrfs@gmx.com>,
	kreijack@inwind.it, dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: btrfs-progs-v4.12: cross compiling
Date: Tue, 15 Aug 2017 14:48:08 +0200	[thread overview]
Message-ID: <20170815124807.GZ2866@twin.jikos.cz> (raw)
In-Reply-To: <082833d5-8f2a-6ed6-fa22-042a161a0dec@gmx.net>

On Tue, Aug 15, 2017 at 02:44:07PM +0200, Hallo32 wrote:
> Am 15.08.2017 um 01:39 schrieb Qu Wenruo:
> > On 2017年08月15日 02:57, Goffredo Baroncelli wrote:
> >> On 08/14/2017 05:10 PM, David Sterba wrote:
> >>> On Mon, Aug 14, 2017 at 10:14:42PM +0800, Qu Wenruo wrote:
> >> [...]
> >>> mktables.c is synced from kernel sources, taking updates from there is
> >>> easier than porting any changes to the proposed scripted 
> >>> implementation.
> >>>
> >>> The workflow is simple:
> >>> - copy kernel mktables.c changes to btrfs-progs mktables.c
> >>
> >> How the kernel deals with this kind of problem ?
> >> Looking at the source of btrfs Makefile, it is more simple to replace
> >>
> >>    mktables: kernel-lib/mktables.c
> >>          @echo "    [CC]     $@"
> >>          $(Q)$(CC) $(CFLAGS) $< -o $@
> >>
> >> with
> >>
> >>
> >>    mktables: kernel-lib/mktables.c
> >>          @echo "    [HOSTCC] $@"
> >>          $(Q)$(HOSTCC) $(CFLAGS) $< -o $@
> >>
> >> where HOSTCC is defined as
> >>
> >> HOSTCC=gcc
> >>
> >>
> >> (may be the same applied also to CFLAGS <-> HOSTCFLAGS ?)
> >
> > If using HOSTCC then I'm fine with it.
> 
> CFLAGS needs also be replaced by something like HOSTCFLAGS, because if 
> you use something like mips/architecture specific CFLAGS, they may be 
> not applicably on the host system.

Good point. Without a regular/automated cross-compilation build testing
I think we could break it quite easily. I'm going to keep the
pregenerated file in git.

  reply	other threads:[~2017-08-15 12:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-14 12:17 btrfs-progs-v4.12: cross compiling Hallo32
2017-08-14 13:06 ` David Sterba
2017-08-14 13:17   ` Qu Wenruo
2017-08-14 14:03     ` David Sterba
2017-08-14 14:14       ` Qu Wenruo
2017-08-14 15:10         ` David Sterba
2017-08-14 18:57           ` Goffredo Baroncelli
2017-08-14 23:39             ` Qu Wenruo
2017-08-15 12:44               ` Hallo32
2017-08-15 12:48                 ` David Sterba [this message]
2017-08-15 17:28                   ` Eric Sandeen
2017-08-15 18:14                     ` Eric Sandeen
2017-08-16  0:13                     ` Qu Wenruo
2017-08-15 19:27           ` Jeff Mahoney
2017-08-14 13:10 ` Qu Wenruo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170815124807.GZ2866@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=Hallo32@gmx.net \
    --cc=kreijack@inwind.it \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox