linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Liu Bo <bo.li.liu@oracle.com>
To: linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.cz>
Subject: [PATCH v3 3/7] Btrfs: remove BUG() in btrfs_extent_inline_ref_size
Date: Fri, 18 Aug 2017 15:15:20 -0600	[thread overview]
Message-ID: <20170818211524.31325-4-bo.li.liu@oracle.com> (raw)
In-Reply-To: <20170818211524.31325-1-bo.li.liu@oracle.com>

Now that btrfs_get_extent_inline_ref_type() can report if type is a
valid one and all callers can gracefully deal with that, we don't need
to crash here.

Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
---
 fs/btrfs/ctree.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index 714e779..38b0735 100644
--- a/fs/btrfs/ctree.h
+++ b/fs/btrfs/ctree.h
@@ -1799,7 +1799,6 @@ static inline u32 btrfs_extent_inline_ref_size(int type)
 	if (type == BTRFS_EXTENT_DATA_REF_KEY)
 		return sizeof(struct btrfs_extent_data_ref) +
 		       offsetof(struct btrfs_extent_inline_ref, offset);
-	BUG();
 	return 0;
 }
 
-- 
2.9.4


  parent reply	other threads:[~2017-08-18 22:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 21:15 [PATCH v3 0/7] add sanity check for extent inline ref type Liu Bo
2017-08-18 21:15 ` [PATCH v3 1/7] Btrfs: add a helper to retrive " Liu Bo
2017-08-21 14:38   ` David Sterba
2017-08-18 21:15 ` [PATCH v3 2/7] Btrfs: convert to use btrfs_get_extent_inline_ref_type Liu Bo
2017-08-21 14:52   ` David Sterba
2017-08-18 21:15 ` Liu Bo [this message]
2017-08-21 14:52   ` [PATCH v3 3/7] Btrfs: remove BUG() in btrfs_extent_inline_ref_size David Sterba
2017-08-18 21:15 ` [PATCH v3 4/7] Btrfs: remove BUG() in print_extent_item Liu Bo
2017-08-21 14:53   ` David Sterba
2017-08-18 21:15 ` [PATCH v3 5/7] Btrfs: remove BUG() in add_data_reference Liu Bo
2017-08-21 14:53   ` David Sterba
2017-08-18 21:15 ` [PATCH v3 6/7] Btrfs: remove BUG_ON in __add_tree_block Liu Bo
2017-08-21 14:59   ` David Sterba
2017-08-18 21:15 ` [PATCH v3 7/7] Btrfs: add one more sanity check for shared ref type Liu Bo
2017-08-21 15:00   ` David Sterba
2017-08-21 15:32 ` [PATCH v3 0/7] add sanity check for extent inline " David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170818211524.31325-4-bo.li.liu@oracle.com \
    --to=bo.li.liu@oracle.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).