From: Liu Bo <bo.li.liu@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: do not reset bio->bi_ops while writing bio
Date: Thu, 24 Aug 2017 11:04:40 -0700 [thread overview]
Message-ID: <20170824180440.GA16386@lim.localdomain> (raw)
In-Reply-To: <20170824141041.GA25871@infradead.org>
On Thu, Aug 24, 2017 at 07:10:41AM -0700, Christoph Hellwig wrote:
> On Wed, Aug 23, 2017 at 12:15:09PM -0600, Liu Bo wrote:
> > flush_epd_write_bio() sets bio->bi_ops by itself to honor REQ_SYNC,
> > but it's not needed at all since bio->bi_ops has set up properly in
> > both __extent_writepage() and write_one_eb(), and in the case of
> > write_one_eb(), it also sets REQ_META, which we will lose in
> > flush_epd_write_bio().
> >
> > This remove this unnecessary bio->bi_ops setting.
>
> Nitpick: it's bi_op, not bi_ops.
Ah thanks, it's bio->bi_opf ;)
thanks,
-liubo
next prev parent reply other threads:[~2017-08-24 18:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 18:15 [PATCH] Btrfs: do not reset bio->bi_ops while writing bio Liu Bo
2017-08-24 14:10 ` Christoph Hellwig
2017-08-24 18:04 ` Liu Bo [this message]
2017-08-25 7:46 ` Christoph Hellwig
2017-09-06 14:42 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170824180440.GA16386@lim.localdomain \
--to=bo.li.liu@oracle.com \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).