* [PATCH] Btrfs: move finish_wait out of the loop
@ 2017-09-01 22:14 Liu Bo
2017-09-06 12:55 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Liu Bo @ 2017-09-01 22:14 UTC (permalink / raw)
To: linux-btrfs
If we're still going to wait after schedule(), we don't have to do
finish_wait() to remove our %wait_queue_entry since prepare_to_wait()
won't add the same %wait_queue_entry twice.
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
---
fs/btrfs/ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index fa1b78c..19e4dec 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -651,8 +651,8 @@ static void btrfs_wait_for_no_snapshoting_writes(struct btrfs_root *root)
if (writers)
schedule();
- finish_wait(&root->subv_writers->wait, &wait);
} while (writers);
+ finish_wait(&root->subv_writers->wait, &wait);
}
static int create_snapshot(struct btrfs_root *root, struct inode *dir,
--
2.9.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Btrfs: move finish_wait out of the loop
2017-09-01 22:14 [PATCH] Btrfs: move finish_wait out of the loop Liu Bo
@ 2017-09-06 12:55 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2017-09-06 12:55 UTC (permalink / raw)
To: Liu Bo; +Cc: linux-btrfs
On Fri, Sep 01, 2017 at 04:14:28PM -0600, Liu Bo wrote:
> If we're still going to wait after schedule(), we don't have to do
> finish_wait() to remove our %wait_queue_entry since prepare_to_wait()
> won't add the same %wait_queue_entry twice.
>
> Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-06 12:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-01 22:14 [PATCH] Btrfs: move finish_wait out of the loop Liu Bo
2017-09-06 12:55 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).