Re: [PATCH 07/10] btrfs: Remove unused parameter from extent_clear_unlock_delalloc

[David Sterba <dsterba@suse.cz>]

On Mon, Aug 21, 2017 at 12:43:47PM +0300, Nikolay Borisov wrote:
> This variable was added as part of ba8b04c1d4ad ("btrfs: extend
> btrfs_set_extent_delalloc and its friends to support in-band dedupe and subpage size patchset")
> however those patchsets haven't materialized yet.
> Let's remove the argument and 
> when the time comes (e.g. whiever patchset lands first) should introduce all of 
> its pre-requisites in the same series. 
> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
> 
> Hello David, 
> 
> I was a ambivalent whether I should send this one since it removes some
> preparatory work. However, the said patchsets haven't really moved anywhere for
> quite some time and will likely require substantial amount of rebasing effort, 
> so let's remove *possibly* outdated leftovers. But then again, I have no 
> strong opinion on this. 

The parameter extension is there so we have chance to merge both
patchsets for testing purposes, which has happened in the past before it
was known that the subpage would need to depend on the other core
changes.

I haven't looked at the recent in-band patches, but I assume it makes
use of the parameter so I'm not going to remove it. Merging patchset
that touches some core functions means lots of manual conflict
resolutions that we've decided to keep the useless parameter just to
make our lives easier.

So, delalloc_end shall be the most irritating unused parameter for now.