From: David Sterba <dsterba@suse.cz>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2 RESEND] Btrfs: make plug in writing meta blocks really work
Date: Wed, 13 Sep 2017 17:51:55 +0200 [thread overview]
Message-ID: <20170913155155.GP29043@twin.jikos.cz> (raw)
In-Reply-To: <20170821215000.2987-1-bo.li.liu@oracle.com>
On Mon, Aug 21, 2017 at 03:49:59PM -0600, Liu Bo wrote:
> We have started plug in btrfs_write_and_wait_marked_extents() but the
> generated IOs actually go to device's schedule IO list where the work
> is doing in another task, thus the started plug doesn't make any
> sense.
>
> And since we wait for IOs immediately after writing meta blocks, it's
> the same case as writing log tree, doing sync submit can merge more
> IOs.
>
> Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
The original patch c6adc9cc082e3 adds too many randomly scattered
blg_plugs that, we could use some high-level comments about the purpose.
next prev parent reply other threads:[~2017-09-13 15:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 21:49 [PATCH 1/2 RESEND] Btrfs: make plug in writing meta blocks really work Liu Bo
2017-08-21 21:50 ` [PATCH 2/2] Btrfs: remove bio_flags which indicates a meta block of log-tree Liu Bo
2017-09-13 16:43 ` David Sterba
2017-09-13 17:11 ` Liu Bo
2017-09-13 18:18 ` [PATCH 2/2 v2] " Liu Bo
2017-09-14 17:02 ` David Sterba
2017-09-13 15:51 ` David Sterba [this message]
2017-09-13 16:45 ` [PATCH 1/2 RESEND] Btrfs: make plug in writing meta blocks really work Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913155155.GP29043@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).