From: David Sterba <dsterba@suse.cz>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] Btrfs: skip checksum when reading compressed data if some IO have failed
Date: Sun, 24 Sep 2017 15:48:50 +0200 [thread overview]
Message-ID: <20170924134850.GU29043@twin.jikos.cz> (raw)
In-Reply-To: <20170920235019.10508-2-bo.li.liu@oracle.com>
On Wed, Sep 20, 2017 at 05:50:19PM -0600, Liu Bo wrote:
> Currently even if the underlying disk reports failure on IO,
> compressed read endio still gets to verify checksum and reports it as
> a checksum error.
>
> In fact, if some IO have failed during reading a compressed data
> extent , there's no way the checksum could match, therefore, we can
> skip that in order to return error quickly to the upper layer.
>
> Please note that we need to do this after recording the failed mirror
> index so that read-repair in the upper layer's endio can work
> properly.
>
> Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
next prev parent reply other threads:[~2017-09-24 13:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 23:50 [PATCH 1/2] Btrfs: fix kernel oops while reading compressed data Liu Bo
2017-09-20 23:50 ` [PATCH 2/2] Btrfs: skip checksum when reading compressed data if some IO have failed Liu Bo
2017-09-24 13:48 ` David Sterba [this message]
2017-09-24 13:04 ` [PATCH 1/2] Btrfs: fix kernel oops while reading compressed data David Sterba
2017-09-24 13:45 ` David Sterba
2017-09-26 8:41 ` Paul Jones
2017-09-26 11:33 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170924134850.GU29043@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox