linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Cc: dsterba@suse.cz
Subject: [PATCH v2 1/3] btrfs: undo writable when sprouting fails
Date: Tue, 26 Sep 2017 15:48:41 +0800	[thread overview]
Message-ID: <20170926074843.31910-2-anand.jain@oracle.com> (raw)
In-Reply-To: <20170926074843.31910-1-anand.jain@oracle.com>

When new device is being added to seed FS, seed FS is marked writable,
but when we fail to bring in the new device, we missed to undo the
writable part. This patch fixes it.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
v2: add commit log
 fs/btrfs/volumes.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 0e8f16c305df..9d64700cc9b6 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -2501,6 +2501,8 @@ int btrfs_init_new_device(struct btrfs_fs_info *fs_info, const char *device_path
 	return ret;
 
 error_trans:
+	if (seeding_dev)
+		sb->s_flags |= MS_RDONLY;
 	btrfs_end_transaction(trans);
 	rcu_string_free(device->name);
 	btrfs_sysfs_rm_device_link(fs_info->fs_devices, device);
-- 
2.13.1


  reply	other threads:[~2017-09-26  7:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-25 12:31 [PATCH 0/3] fix bug in btrfs_init_new_device() Anand Jain
2017-09-25 12:31 ` [PATCH 1/3] btrfs: undo writable when sprouting fails Anand Jain
2017-09-25 13:03   ` Qu Wenruo
2017-09-25 14:52   ` David Sterba
2017-09-25 12:31 ` [PATCH 2/3] btrfs: cleanup btrfs_init_new_device() Anand Jain
2017-09-25 13:07   ` Nikolay Borisov
2017-09-25 13:09     ` Nikolay Borisov
2017-09-26  7:57       ` Anand Jain
2017-09-26  8:00         ` Anand Jain
2017-09-26  8:07         ` Nikolay Borisov
2017-09-26  8:45           ` Anand Jain
2017-09-25 13:08   ` Qu Wenruo
2017-09-25 14:56   ` David Sterba
2017-09-25 12:31 ` [PATCH 3/3] btrfs: fix BUG_ON in btrfs_init_new_device() Anand Jain
2017-09-26  7:48 ` [PATCH v2 0/3] fix bug " Anand Jain
2017-09-26  7:48   ` Anand Jain [this message]
2017-09-26  7:48   ` [PATCH v2 2/3] btrfs: cleanup btrfs_init_new_device() Anand Jain
2017-09-26  7:48   ` [PATCH v2 3/3] btrfs: fix BUG_ON in btrfs_init_new_device() Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170926074843.31910-2-anand.jain@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).