From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs: fix send ioctl on 32bit with 64bit kernel
Date: Wed, 27 Sep 2017 12:52:50 +0200 [thread overview]
Message-ID: <20170927105250.GX31640@twin.jikos.cz> (raw)
In-Reply-To: <1506458409-2428-1-git-send-email-jbacik@fb.com>
On Tue, Sep 26, 2017 at 04:40:09PM -0400, Josef Bacik wrote:
> We pass in a pointer in our send arg struct, this means the struct size doesn't
> match with 32bit user space and 64bit kernel space. Fix this by adding a compat
> mode and doing the appropriate conversion.
How does this differ from the existing workaround that adds the 32bit
structure (btrfs_ioctl_timespec_32 and
btrfs_ioctl_received_subvol_args_32 at the top of ioctl.c) and the
btrfs_compat_ioctl() (at the end of ioctl.c)?
next prev parent reply other threads:[~2017-09-27 10:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 20:40 [PATCH] btrfs: fix send ioctl on 32bit with 64bit kernel Josef Bacik
2017-09-27 10:52 ` David Sterba [this message]
2017-09-27 14:40 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927105250.GX31640@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox