From: Timofey Titovets <nefelim4ag@gmail.com>
To: linux-btrfs@vger.kernel.org
Cc: Timofey Titovets <nefelim4ag@gmail.com>
Subject: [PATCH 3/4] Btrfs: handle unaligned tail of data ranges more efficient
Date: Tue, 3 Oct 2017 18:06:03 +0300 [thread overview]
Message-ID: <20171003150604.19596-4-nefelim4ag@gmail.com> (raw)
In-Reply-To: <20171003150604.19596-1-nefelim4ag@gmail.com>
At now while switch page bits in data ranges
we always hande +1 page, for cover case
where end of data range is not page aligned
Let's handle that case more obvious and efficient
Check end aligment directly and touch +1 page
only then needed
Signed-off-by: Timofey Titovets <nefelim4ag@gmail.com>
---
fs/btrfs/extent_io.c | 12 ++++++++++--
fs/btrfs/inode.c | 6 +++++-
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index 0538bf85adc3..131b7d1df9f7 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -1359,7 +1359,11 @@ void extent_range_clear_dirty_for_io(struct inode *inode, u64 start, u64 end)
unsigned long end_index = end >> PAGE_SHIFT;
struct page *page;
- while (index <= end_index) {
+ /* Don't miss unaligned end */
+ if (!IS_ALIGNED(end, PAGE_SIZE))
+ end_index++;
+
+ while (index < end_index) {
page = find_get_page(inode->i_mapping, index);
BUG_ON(!page); /* Pages should be in the extent_io_tree */
clear_page_dirty_for_io(page);
@@ -1374,7 +1378,11 @@ void extent_range_redirty_for_io(struct inode *inode, u64 start, u64 end)
unsigned long end_index = end >> PAGE_SHIFT;
struct page *page;
- while (index <= end_index) {
+ /* Don't miss unaligned end */
+ if (!IS_ALIGNED(end, PAGE_SIZE))
+ end_index++;
+
+ while (index < end_index) {
page = find_get_page(inode->i_mapping, index);
BUG_ON(!page); /* Pages should be in the extent_io_tree */
__set_page_dirty_nobuffers(page);
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index b6e81bd650ea..b4974d969f67 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -10799,7 +10799,11 @@ void btrfs_set_range_writeback(void *private_data, u64 start, u64 end)
unsigned long end_index = end >> PAGE_SHIFT;
struct page *page;
- while (index <= end_index) {
+ /* Don't miss unaligned end */
+ if (!IS_ALIGNED(end, PAGE_SIZE))
+ end_index++;
+
+ while (index < end_index) {
page = find_get_page(inode->i_mapping, index);
ASSERT(page); /* Pages should be in the extent_io_tree */
set_page_writeback(page);
--
2.14.2
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-
next prev parent reply other threads:[~2017-10-03 15:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 15:06 [PATCH 0/4] Just bunch of btrfs patches Timofey Titovets
2017-10-03 15:06 ` [PATCH 1/4] Btrfs: compress_file_range() remove dead variable num_bytes Timofey Titovets
2017-10-10 17:39 ` David Sterba
2017-10-03 15:06 ` [PATCH 2/4] Btrfs: clear_dirty only on pages only in compression range Timofey Titovets
2017-10-10 16:22 ` David Sterba
2017-10-13 22:31 ` Timofey Titovets
2017-10-03 15:06 ` Timofey Titovets [this message]
2017-10-10 16:37 ` [PATCH 3/4] Btrfs: handle unaligned tail of data ranges more efficient David Sterba
2017-10-15 22:09 ` Timofey Titovets
2017-10-17 15:52 ` David Sterba
2017-10-03 15:06 ` [PATCH 4/4] Btrfs: btrfs_dedupe_file_range() ioctl, remove 16MiB restriction Timofey Titovets
2017-10-10 17:36 ` David Sterba
2017-11-14 10:19 ` Timofey Titovets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171003150604.19596-4-nefelim4ag@gmail.com \
--to=nefelim4ag@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).