From: David Sterba <dsterba@suse.cz>
To: "Misono, Tomohiro" <misono.tomohiro@jp.fujitsu.com>
Cc: dsterba@suse.cz, Hugo Mills <hugo@carfax.org.uk>,
Andrei Borzenkov <arvidjaar@gmail.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2] btrfs-progs: subvol: change subvol set-default to also accept subvol path
Date: Thu, 5 Oct 2017 17:14:00 +0200 [thread overview]
Message-ID: <20171005151400.GI3521@twin.jikos.cz> (raw)
In-Reply-To: <22943aba-b9c5-b16b-755f-d0c795280d51@jp.fujitsu.com>
On Thu, Oct 05, 2017 at 09:57:25AM +0900, Misono, Tomohiro wrote:
> > I agree with Andrei and Hugo. We need to check that the subvolume path
> > belongs to the filesystem anyway. I don't see that in the first version,
> > so please fix it.
> >
>
> I'm a bit confusing, but what is the meaning of "We need to check that the subvolume
> path belongs to the filesystem"? Do you mean we should check whether the fs of current
> directory and the fs of the subvolume specified are the same or not? However, current
> "set-default <id> <path>" does not check the <path> belong the same fs or not either.
> Also, what if the subvolume is specified by absolute path?
Ah my bad, specifying by path is enough of course. So the expected use
is:
filesystem mounted under /mnt
$ cd /mnt
$ btrfs subvol set-default ./subvol1
or
$ cd /
$ btrfs subvol set-default /mnt/subvol1
prev parent reply other threads:[~2017-10-05 15:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 8:19 [PATCH v2] btrfs-progs: subvol: change subvol set-default to also accept subvol path Misono, Tomohiro
2017-10-02 8:39 ` Andrei Borzenkov
2017-10-02 9:01 ` Hugo Mills
2017-10-02 23:57 ` Misono, Tomohiro
2017-10-04 18:07 ` David Sterba
2017-10-05 0:57 ` Misono, Tomohiro
2017-10-05 15:14 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005151400.GI3521@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=arvidjaar@gmail.com \
--cc=hugo@carfax.org.uk \
--cc=linux-btrfs@vger.kernel.org \
--cc=misono.tomohiro@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox