From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.com
Subject: Re: [PATCH v2 2/2] btrfs: Fix transaction abort during failure in btrfs_rm_dev_item
Date: Fri, 6 Oct 2017 18:14:43 +0200 [thread overview]
Message-ID: <20171006161443.GT3521@twin.jikos.cz> (raw)
In-Reply-To: <1506588327-6616-2-git-send-email-nborisov@suse.com>
On Thu, Sep 28, 2017 at 11:45:27AM +0300, Nikolay Borisov wrote:
> btrfs_rm_dev_item calls several function under an activa transaction, however
> it fails to abort it if an error happens. Fix this by adding explicit
> btrfs_abort_transaction/btrfs_end_transaction calls
>
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
> ---
>
> v2:
> * Explicitly handle every failure case w.r.t transaction abort rather than
> rely on final btrfs_commit_transaction() to do the right thing.
>
> * Also consider the -ENOENT case from btrfs_search_slot as a failure.
The devid is checked in the caller, outside of the transaction, so it is
fine to abort here, the devid is supposed to be there.
Reviewed-by: David Sterba <dsterba@suse.com>
next prev parent reply other threads:[~2017-10-06 16:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-27 10:48 [PATCH 0/3] Few transaction semantic fixes Nikolay Borisov
2017-09-27 10:48 ` [PATCH 1/3] btrfs: Remove unnecessary btrfs_abort_transaction on transaction commit failure Nikolay Borisov
2017-09-27 10:48 ` [PATCH 2/3] btrfs: Handle failure to add to add received uuid to uuid tree in _btrfs_ioctl_set_received_subvol Nikolay Borisov
2017-09-27 10:48 ` [PATCH 3/3] btrfs: Fix transaction abort during failure in btrfs_rm_dev_item Nikolay Borisov
2017-09-28 8:45 ` [PATCH v2 1/2] btrfs: Refactor transaction handling Nikolay Borisov
2017-09-28 8:45 ` [PATCH v2 2/2] btrfs: Fix transaction abort during failure in btrfs_rm_dev_item Nikolay Borisov
2017-10-06 16:14 ` David Sterba [this message]
2017-10-19 11:54 ` David Sterba
2017-10-19 13:26 ` Nikolay Borisov
2017-10-20 6:30 ` [PATCH v3] " Nikolay Borisov
2017-10-23 6:58 ` [PATCH v4] " Nikolay Borisov
2017-10-23 16:29 ` Edmund Nadolski
2017-10-30 15:02 ` David Sterba
2017-10-06 16:11 ` [PATCH v2 1/2] btrfs: Refactor transaction handling David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171006161443.GT3521@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).