From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v2 2/4] btrfs: fix EIO misuse to report missing degraded option
Date: Mon, 9 Oct 2017 11:07:44 +0800 [thread overview]
Message-ID: <20171009030746.16680-2-anand.jain@oracle.com> (raw)
In-Reply-To: <20171009030746.16680-1-anand.jain@oracle.com>
EIO is only for the IO failure to the device, avoid it.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
v2: This patch is renamed from
[PATCH 1/2] btrfs: fix read_one_chunk() return error code
fs/btrfs/volumes.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 2f500a32089e..844ae25cff9e 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -6448,7 +6448,7 @@ static int read_one_chunk(struct btrfs_fs_info *fs_info, struct btrfs_key *key,
!btrfs_test_opt(fs_info, DEGRADED)) {
free_extent_map(em);
btrfs_report_missing_device(fs_info, devid, uuid);
- return -EIO;
+ return -ENOENT;
}
if (!map->stripes[i].dev) {
map->stripes[i].dev =
@@ -6581,7 +6581,7 @@ static int read_one_dev(struct btrfs_fs_info *fs_info,
if (!device) {
if (!btrfs_test_opt(fs_info, DEGRADED)) {
btrfs_report_missing_device(fs_info, devid, dev_uuid);
- return -EIO;
+ return -ENOENT;
}
device = add_missing_dev(fs_devices, devid, dev_uuid);
@@ -6592,7 +6592,7 @@ static int read_one_dev(struct btrfs_fs_info *fs_info,
if (!device->bdev) {
btrfs_report_missing_device(fs_info, devid, dev_uuid);
if (!btrfs_test_opt(fs_info, DEGRADED))
- return -EIO;
+ return -ENOENT;
}
if(!device->bdev && !device->missing) {
--
2.7.0
next prev parent reply other threads:[~2017-10-09 3:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 3:07 [PATCH v2 1/4] btrfs: add_missing_dev() should return the actual error Anand Jain
2017-10-09 3:07 ` Anand Jain [this message]
2017-10-13 12:16 ` [PATCH v2 2/4] btrfs: fix EIO misuse to report missing degraded option David Sterba
2017-10-09 3:07 ` [PATCH v2 3/4] btrfs: declare btrfs_report_missing_device() static Anand Jain
2017-10-09 3:07 ` [PATCH v2 4/4] btrfs: fix use of error or warning for missing device Anand Jain
2017-10-11 0:52 ` [PATCH v2 1/4] btrfs: add_missing_dev() should return the actual error Liu Bo
2017-10-11 4:34 ` [PATCH v2.1 " Anand Jain
2017-10-11 4:46 ` [PATCH v3 " Anand Jain
2017-10-13 12:14 ` David Sterba
2017-10-13 12:28 ` [PATCH v2 " David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171009030746.16680-2-anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).