[PATCH] btrfs: Use bd_dev to generate index when dev_state_hashtable add items.

[PATCH] btrfs: Use bd_dev to generate index when dev_state_hashtable add items.

[Gu Jinxiang]

From: Gu JinXiang <gujx@cn.fujitsu.com>

Fix bug of
<f8f84b2dfda5> (<btrfs: index check-integrity state hash by a dev_t>).

Signed-off-by: Gu JinXiang <gujx@cn.fujitsu.com>
---
 fs/btrfs/check-integrity.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c
index 9d3854839038..86d79bc4cfb3 100644
--- a/fs/btrfs/check-integrity.c
+++ b/fs/btrfs/check-integrity.c
@@ -613,7 +613,7 @@ static void btrfsic_dev_state_hashtable_add(
 		struct btrfsic_dev_state_hashtable *h)
 {
 	const unsigned int hashval =
-	    (((unsigned int)((uintptr_t)ds->bdev)) &
+	    (((unsigned int)((uintptr_t)ds->bdev->bd_dev)) &
 	     (BTRFSIC_DEV2STATE_HASHTABLE_SIZE - 1));
 
 	list_add(&ds->collision_resolving_node, h->table + hashval);
-- 
2.13.5

Re: [PATCH] btrfs: Use bd_dev to generate index when dev_state_hashtable add items.

[David Sterba]

On Fri, Sep 29, 2017 at 04:16:35PM +0800, Gu Jinxiang wrote:
> From: Gu JinXiang <gujx@cn.fujitsu.com>
> 
> Fix bug of
> <f8f84b2dfda5> (<btrfs: index check-integrity state hash by a dev_t>).

Please explain what bug are you fixing.

RE: [PATCH] btrfs: Use bd_dev to generate index when dev_state_hashtable add items.

[Gu, Jinxiang]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 883 bytes --]

Hi,
sorry for reply too late.

This patch fix for the bug descriped below.
Use MOUNT_OPTIONS="-o check_int" when run xfstest, device
Can not be mount successfully. So xfstest can not run.



> -----Original Message-----
> From: David Sterba [mailto:dsterba@suse.cz]
> Sent: Saturday, September 30, 2017 2:05 AM
> To: Gu, Jinxiang/¹Ë ½ðÏã <gujx@cn.fujitsu.com>
> Cc: linux-btrfs@vger.kernel.org; hch@lst.de
> Subject: Re: [PATCH] btrfs: Use bd_dev to generate index when dev_state_hashtable add items.
> 
> On Fri, Sep 29, 2017 at 04:16:35PM +0800, Gu Jinxiang wrote:
> > From: Gu JinXiang <gujx@cn.fujitsu.com>
> >
> > Fix bug of
> > <f8f84b2dfda5> (<btrfs: index check-integrity state hash by a dev_t>).
> 
> Please explain what bug are you fixing.
> 



ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±ý»k~ÏâžØ^n‡r¡ö¦zË\x1aëh™¨è­Ú&£ûàz¿äz¹Þ—ú+€Ê+zf£¢·hšˆ§~†­†Ûiÿÿïêÿ‘êçz_è®\x0fæj:+v‰¨þ)ߣøm

Re: [PATCH] btrfs: Use bd_dev to generate index when dev_state_hashtable add items.

[David Sterba]

On Mon, Oct 09, 2017 at 01:54:14AM +0000, Gu, Jinxiang wrote:
> Hi,
> sorry for reply too late.
> 
> This patch fix for the bug descriped below.
> Use MOUNT_OPTIONS="-o check_int" when run xfstest, device
> Can not be mount successfully. So xfstest can not run.

So please update the changelog and resend. Thanks.