linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH] btrfs: remove BUG_ON in btrfs_rm_dev_replace_free_srcdev()
Date: Thu, 12 Oct 2017 17:00:41 +0800	[thread overview]
Message-ID: <20171012090041.7438-1-anand.jain@oracle.com> (raw)

That was only an extra check to tackle few bugs around this
area, now its save to remove it.

Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
 fs/btrfs/volumes.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 332e00e72b86..0a5251a34d58 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -2015,16 +2015,12 @@ void btrfs_rm_dev_replace_free_srcdev(struct btrfs_fs_info *fs_info,
 	}
 
 	btrfs_close_bdev(srcdev);
-
 	call_rcu(&srcdev->rcu, free_device);
 
 	/*
-	 * unless fs_devices is seed fs, num_devices shouldn't go
-	 * zero
+	 * If this is no devs we rather delete the fs_devices
+	 * which is true in case of single device seeding fs.
 	 */
-	BUG_ON(!fs_devices->num_devices && !fs_devices->seeding);
-
-	/* if this is no devs we rather delete the fs_devices */
 	if (!fs_devices->num_devices) {
 		struct btrfs_fs_devices *tmp_fs_devices;
 
-- 
2.13.1


             reply	other threads:[~2017-10-12  9:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12  9:00 Anand Jain [this message]
2017-10-16 14:45 ` [PATCH] btrfs: remove BUG_ON in btrfs_rm_dev_replace_free_srcdev() David Sterba
2017-10-16 22:53   ` [PATCH v2] " Anand Jain
2017-10-16 23:32   ` [PATCH] " Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171012090041.7438-1-anand.jain@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).