* [PATCH] configure.ac: allow '--with-convert=' to accept comma-separated values
@ 2017-10-12 12:08 Sergei Trofimovich
2017-10-12 12:30 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Sergei Trofimovich @ 2017-10-12 12:08 UTC (permalink / raw)
To: David Sterba; +Cc: Sergei Trofimovich, linux-btrfs
Before the change configure refused to accept it's defaults explicitly:
$ ./configure --enable-convert --with-convert=ext2,reiserfs
...
configure: error: unknown tokens for --with-convert: ,
After the change both converters are enabled:
$ ./configure --enable-convert --with-convert=ext2,reiserfs
...
btrfs-convert: yes (ext2,reiserfs)
Cc: linux-btrfs@vger.kernel.org
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index f273bbe9..adceafc3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -148,7 +148,7 @@ AC_SUBST([BTRFSCONVERT_EXT2])
AC_SUBST([BTRFSCONVERT_REISERFS])
# catch typos
-tmp=$(echo "$with_convert" | sed -e 's/auto//' | sed -e 's/ext2//' | sed -e 's/reiserfs//' | sed -e 's/,\+/,/')
+tmp=$(echo "$with_convert" | sed -e 's/auto//' | sed -e 's/ext2//' | sed -e 's/reiserfs//' | sed -e 's/,\+//')
if ! test "x$tmp" = "x"; then
AC_MSG_ERROR([unknown tokens for --with-convert: $tmp])
fi
--
2.14.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] configure.ac: allow '--with-convert=' to accept comma-separated values
2017-10-12 12:08 [PATCH] configure.ac: allow '--with-convert=' to accept comma-separated values Sergei Trofimovich
@ 2017-10-12 12:30 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2017-10-12 12:30 UTC (permalink / raw)
To: Sergei Trofimovich; +Cc: linux-btrfs
On Thu, Oct 12, 2017 at 01:08:54PM +0100, Sergei Trofimovich wrote:
> Before the change configure refused to accept it's defaults explicitly:
> $ ./configure --enable-convert --with-convert=ext2,reiserfs
> ...
> configure: error: unknown tokens for --with-convert: ,
>
> After the change both converters are enabled:
> $ ./configure --enable-convert --with-convert=ext2,reiserfs
> ...
> btrfs-convert: yes (ext2,reiserfs)
>
> Cc: linux-btrfs@vger.kernel.org
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-12 12:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-12 12:08 [PATCH] configure.ac: allow '--with-convert=' to accept comma-separated values Sergei Trofimovich
2017-10-12 12:30 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).