From: Tejun Heo <tj@kernel.org>
To: dsterba@suse.cz, jack@suse.cz, axboe@kernel.dk, clm@fb.com,
jbacik@fb.com, kernel-team@fb.com, linux-kernel@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 5/5] btrfs: ensure that metadata and flush are issued from the root cgroup
Date: Thu, 12 Oct 2017 08:38:54 -0700 [thread overview]
Message-ID: <20171012153854.GR3301751@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20171011170723.GX3521@twin.jikos.cz>
On Wed, Oct 11, 2017 at 07:07:23PM +0200, David Sterba wrote:
> The comment is useful, but the condition will be always true, so I don't
> see the point.
>
> /*
> * The btree_inode will be always in the root cgroup. The cgroup
> * writeback can be enabled on regular inodes selectively.
> */
> new_fl |= S_CGROUPWB;
>
> is IMHO enough, based on my reading of patch 2/5 changelog.
Will update accordingly.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-10-12 15:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 15:54 [PATCHSET v2] cgroup, writeback, btrfs: make sure btrfs issues metadata IOs from the root cgroup Tejun Heo
2017-10-10 15:54 ` [PATCH 1/5] blkcg: export blkcg_root_css Tejun Heo
2017-10-11 7:50 ` Jan Kara
2017-10-10 15:54 ` [PATCH 2/5] cgroup, writeback: replace SB_I_CGROUPWB with per-inode S_CGROUPWB Tejun Heo
2017-10-10 15:54 ` [PATCH 3/5] buffer_head: separate out create_bh_bio() from submit_bh_wbc() Tejun Heo
2017-10-11 7:54 ` Jan Kara
2017-10-10 15:54 ` [PATCH 4/5] cgroup, buffer_head: implement submit_bh_blkcg_css() Tejun Heo
2017-10-11 7:55 ` Jan Kara
2017-10-10 15:54 ` [PATCH 5/5] btrfs: ensure that metadata and flush are issued from the root cgroup Tejun Heo
2017-10-10 16:43 ` [PATCH v2 " Tejun Heo
2017-10-10 17:45 ` Liu Bo
2017-10-11 17:07 ` David Sterba
2017-10-12 15:38 ` Tejun Heo [this message]
2017-10-12 17:06 ` [PATCH v3 " Tejun Heo
2017-10-12 18:56 ` David Sterba
2017-11-29 16:56 ` [PATCHSET v2] cgroup, writeback, btrfs: make sure btrfs issues metadata IOs " Jan Kara
2017-11-29 17:03 ` Tejun Heo
2017-11-29 17:05 ` Tejun Heo
2017-11-29 18:38 ` Chris Mason
2017-11-30 17:23 ` David Sterba
2017-11-30 17:34 ` Chris Mason
2017-12-01 10:52 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012153854.GR3301751@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).