From: Liu Bo <bo.li.liu@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: add write_flags for compression bio
Date: Mon, 16 Oct 2017 10:34:49 -0700 [thread overview]
Message-ID: <20171016173449.GD19440@localhost.localdomain> (raw)
In-Reply-To: <20171016133310.GI3521@twin.jikos.cz>
On Mon, Oct 16, 2017 at 03:33:10PM +0200, David Sterba wrote:
> On Fri, Oct 13, 2017 at 03:10:35PM -0600, Liu Bo wrote:
> > Compression code path has only flaged bios with REQ_OP_WRITE no matter
> > where the bios come from. This breaks the rule that sync writes and
> > writeback writes need to be differentiated from each other.
>
> What are the implications of the change?
All writes need to have the correct bio flag so that block layer can
recognize them to do throttle or other stuff. Compression writes are
no exception, but currently we don't attach the correct bio flag to
either compressed writeback writes or compressed sync writes.
Does it make sense?
Thanks,
-liubo
next prev parent reply other threads:[~2017-10-16 17:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 21:10 [PATCH] Btrfs: add write_flags for compression bio Liu Bo
2017-10-16 13:33 ` David Sterba
2017-10-16 17:34 ` Liu Bo [this message]
2017-10-24 5:18 ` [PATCH v2] " Liu Bo
2017-10-30 13:33 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016173449.GD19440@localhost.localdomain \
--to=bo.li.liu@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).