From: David Sterba <dsterba@suse.cz>
To: Timofey Titovets <nefelim4ag@gmail.com>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v8 0/6] Btrfs: populate heuristic with code
Date: Tue, 24 Oct 2017 21:23:11 +0200 [thread overview]
Message-ID: <20171024192311.GU3521@suse.cz> (raw)
In-Reply-To: <CAGqmi75xXn7gmAG5DNCH=drfVH0oboP_tDLWzHUQJtvzyDsjGQ@mail.gmail.com>
On Sun, Oct 22, 2017 at 04:44:04PM +0300, Timofey Titovets wrote:
> 2017-10-20 16:45 GMT+03:00 David Sterba <dsterba@suse.cz>:
> > On Fri, Oct 20, 2017 at 01:48:01AM +0300, Timofey Titovets wrote:
> >> 2017-10-19 18:39 GMT+03:00 David Sterba <dsterba@suse.cz>:
> >> > On Fri, Sep 29, 2017 at 06:22:00PM +0200, David Sterba wrote:
> >> >> On Thu, Sep 28, 2017 at 05:33:35PM +0300, Timofey Titovets wrote:
> >> >> > Compile tested, hand tested on live system
> >> >> >
> >> >> > Change v7 -> v8
> >> >> > - All code moved to compression.c (again)
> >> >> > - Heuristic workspaces inmplemented another way
> >> >> > i.e. only share logic with compression workspaces
> >> >> > - Some style fixes suggested by Devid
> >> >> > - Move sampling function from heuristic code
> >> >> > (I'm afraid of big functions)
> >> >> > - Much more comments and explanations
> >> >>
> >> >> Thanks for the update, I went through the patches and they looked good
> >> >> enough to be put into for-next. I may have more comments about a few
> >> >> things, but nothing serious that would hinder testing.
> >> >
> >> > I did a final pass through the patches and edited comments wehre I was
> >> > not able to undrerstand them. Please check the updated patches in [1] if
> >> > I did not accidentally change the meaning.
> >>
> >> I don't see a link [1] in mail, may be you missed it?
> >
> > Yeah, sorry:
> > https://github.com/kdave/btrfs-devel/commits/ext/timofey/heuristic
>
> I did re-read updated comments, looks ok to me
> (i only found one typo, leave a comment).
Thanks, fixed and branch added to the rest for 4.15.
prev parent reply other threads:[~2017-10-24 19:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 14:33 [PATCH v8 0/6] Btrfs: populate heuristic with code Timofey Titovets
2017-09-28 14:33 ` [PATCH v8 1/6] Btrfs: compression.c separated heuristic/compression workspaces Timofey Titovets
2017-09-28 14:33 ` [PATCH v8 2/6] Btrfs: heuristic workspace add bucket and sample items, macros Timofey Titovets
2017-09-28 14:33 ` [PATCH v8 3/6] Btrfs: implement heuristic sampling logic Timofey Titovets
2017-09-28 14:33 ` [PATCH v8 4/6] Btrfs: heuristic add detection of repeated data patterns Timofey Titovets
2017-09-28 14:33 ` [PATCH v8 5/6] Btrfs: heuristic add byte set calculation Timofey Titovets
2017-09-28 14:33 ` [PATCH v8 6/6] Btrfs: heuristic add byte core " Timofey Titovets
2017-09-29 16:22 ` [PATCH v8 0/6] Btrfs: populate heuristic with code David Sterba
2017-10-19 15:39 ` David Sterba
2017-10-19 22:48 ` Timofey Titovets
2017-10-20 13:45 ` David Sterba
2017-10-22 13:44 ` Timofey Titovets
2017-10-23 18:36 ` Timofey Titovets
2017-10-24 19:23 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171024192311.GU3521@suse.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nefelim4ag@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).