From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: dsterba@suse.cz
Subject: [PATCH v2 0/6] btrfs: qgroup: Separate qgroup reservation types
Date: Wed, 25 Oct 2017 10:54:39 +0800 [thread overview]
Message-ID: <20171025025445.16617-1-wqu@suse.com> (raw)
This patchset will separate original qgroup->reserved into a new
structure, btrfs_qgroup_rsv, which has different reservation for
different types.
Currently it will only includes data and meta type.
The main advantage is:
1) Better underflow detection
Now it can detection which reservation type is causing the underflow.
2) Easier to expend
All interface is updated to access reservation type, it will get
super easy to be expended, especially for later delalloc reservation.
3) Better encapsulation
No longer need to manually trace underflow or add trace events, all
encapsulated into 2 functions.
Despite of the qgroup reservation refactor, also fix a bug where qgroup
relationship update modifies parent qgroup reservation wrongly.
Although I tend to agree with Jeff's idea to remove support of
multi-level qgroup, at least fix what I exposed during coding.
Changelog:
v2:
Use _MAX naming, as _TYPES naming reusing the last type makes it quite
easier to screw up space allocation, since we need +1 to handle
_TYPES. Suggested by Nikolay, Edmund, Jeff and already experienced
such problem by myself.
Rename the qgroup_rsv_increase/decrease() to qgroup_rsv_add/release(),
to follow the block_rsv API, suggested by Nikolay, Jeff and Edmund.
Better description for the bug in __qgroup_excl_accounting(),
suggested by Nikolay.
Qu Wenruo (6):
btrfs: qgroup: Skeleton to support separate qgroup reservation type
btrfs: qgroup: Introduce helpers to update and access new qgroup rsv
btrfs: qgroup: Make qgroup_reserve and its callers to use separate
reservation type
btrfs: qgroup: Fix wrong qgroup reservation update for relationship
modification
btrfs: qgroup: Update trace events to use new separate rsv types
btrfs: qgroup: Cleanup the remaining old reservation counters
fs/btrfs/qgroup.c | 169 ++++++++++++++++++++++++++++++-------------
fs/btrfs/qgroup.h | 28 ++++++-
include/trace/events/btrfs.h | 17 +++--
3 files changed, 154 insertions(+), 60 deletions(-)
--
2.14.2
next reply other threads:[~2017-10-25 2:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 2:54 Qu Wenruo [this message]
2017-10-25 2:54 ` [PATCH v2 1/6] btrfs: qgroup: Skeleton to support separate qgroup reservation type Qu Wenruo
2017-10-25 2:54 ` [PATCH v2 2/6] btrfs: qgroup: Introduce helpers to update and access new qgroup rsv Qu Wenruo
2017-10-25 2:54 ` [PATCH v2 3/6] btrfs: qgroup: Make qgroup_reserve and its callers to use separate reservation type Qu Wenruo
2017-10-25 2:54 ` [PATCH v2 4/6] btrfs: qgroup: Fix wrong qgroup reservation update for relationship modification Qu Wenruo
2017-10-26 14:00 ` Nikolay Borisov
2017-10-26 14:12 ` Qu Wenruo
2017-10-25 2:54 ` [PATCH v2 5/6] btrfs: qgroup: Update trace events to use new separate rsv types Qu Wenruo
2017-10-25 2:54 ` [PATCH v2 6/6] btrfs: qgroup: Cleanup the remaining old reservation counters Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171025025445.16617-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).