From: David Sterba <dsterba@suse.cz>
To: "Gu, Jinxiang" <gujx@cn.fujitsu.com>
Cc: Qu Wenruo <wqu@suse.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"dsterba@suse.cz" <dsterba@suse.cz>
Subject: Re: [PATCH] btrfs-progs: convert: Open the fs readonly for rollback
Date: Thu, 26 Oct 2017 19:16:57 +0200 [thread overview]
Message-ID: <20171026171657.GB3521@twin.jikos.cz> (raw)
In-Reply-To: <516DDBE5B1D92D42BCF7A2E37F045A5D01479E236E@G08CNEXMBPEKD02.g08.fujitsu.local>
On Thu, Oct 26, 2017 at 08:35:29AM +0000, Gu, Jinxiang wrote:
> > Cc: dsterba@suse.cz
> > Subject: [PATCH] btrfs-progs: convert: Open the fs readonly for rollback
> >
> > For rollback, we only needs to open the fs to check if it meets the condition to rollback.
> > And this RW read makes us failed to rollback btrfs with v2 space cache.
> >
> > In fact, we don't even start a transaction during rollback.
> >
> > So open the fs RO for rollback, to avoid v2 space cache problem.
> >
> > Reported-by: Gu Jinxiang <gujx@cn.fujitsu.com>
> > Signed-off-by: Qu Wenruo <wqu@suse.com>
> Reviewed-by: Gu JinXiang <gujx@cn.fujitsu.com>
> Tested-by: Gu JinXiang <gujx@cn.fujitsu.com>
Applied, thanks.
prev parent reply other threads:[~2017-10-26 17:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 7:28 [PATCH] btrfs-progs: convert: Open the fs readonly for rollback Qu Wenruo
2017-10-26 8:35 ` Gu, Jinxiang
2017-10-26 17:16 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026171657.GB3521@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=gujx@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).