From: David Sterba <dsterba@suse.cz>
To: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
Cc: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: Re: [PATCH v2 1/3] btrfs-progs: Refactor test_minimum_size to use calculated minimal device size
Date: Thu, 26 Oct 2017 19:52:03 +0200 [thread overview]
Message-ID: <20171026175203.GD3521@twin.jikos.cz> (raw)
In-Reply-To: <20171016083112.GC495@fnst.localdomain>
On Mon, Oct 16, 2017 at 04:31:12PM +0800, Lu Fengqi wrote:
> On Mon, Oct 16, 2017 at 04:22:56PM +0800, Qu Wenruo wrote:
> >test_minimum_size() function is only called to check if provided device
> >is large enough.
> >
> >However the minimal device size only needs to be calculated once, and
> >can be reused everywhere.
> >
> >Refactor that function to make later modification easier.
> >
> >Signed-off-by: Qu Wenruo <wqu@suse.com>
>
> Reviewed-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
Applied, thanks.
prev parent reply other threads:[~2017-10-26 17:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 8:22 [PATCH v2 1/3] btrfs-progs: Refactor test_minimum_size to use calculated minimal device size Qu Wenruo
2017-10-16 8:22 ` [PATCH v2 2/3] btrfs-progs: mkfs: Enhance minimal device size calculation to fix mkfs failure on small file Qu Wenruo
2017-10-16 9:16 ` Nikolay Borisov
2017-10-16 8:22 ` [PATCH v2 3/3] btrfs-progs: test/mkfs: Test if the minimal device size is valid Qu Wenruo
2017-10-26 17:45 ` David Sterba
2017-10-27 0:26 ` Qu Wenruo
2017-10-16 8:31 ` [PATCH v2 1/3] btrfs-progs: Refactor test_minimum_size to use calculated minimal device size Lu Fengqi
2017-10-26 17:52 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026175203.GD3521@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=lufq.fnst@cn.fujitsu.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).