Re: [PATCH 2/4] btrfs-progs: fsck: Introduce --fix-dev-size option

[David Sterba <dsterba@suse.cz>]

On Wed, Oct 11, 2017 at 08:43:24AM +0800, Qu Wenruo wrote:
> On 2017年10月10日 21:16, David Sterba wrote:
> > On Tue, Oct 10, 2017 at 07:51:11AM +0000, Qu Wenruo wrote:
> >> Introduce --fix-dev-size option to fix device related problems.
> > 
> > Please don't add it to 'check', this is not the right place for the
> > targeted fixes. -> 'btrfs rescue'
> 
> I'm OK moving the super total_bytes fix to 'btrfs rescue'.
> 
> But what about the alignment/mismatch detection part?
> Is it still OK to detect them in 'btrfs check'?
> 
> And further more, the unaligned device total_bytes problem is not a big 
> problem that fits into 'rescue' territory.
> 
> I'm not really sure about the difference between rescue and check.

Check is supposed to find the problems, and rescue command group is for
specific fixes that are not suitable for 'check'. This is to avoid too
many specific options for 'check' and all the possible combinations.

We'll fix the total_bytes bug and don't expect it to be a problem in the
future again, so we can forget about the subcommand in rescue.

What should check report if it detects this kind of inconsistencies,
that's a good question. It could either fix them automatically (if it's
safe) or point to the specific command.