From: David Sterba <dsterba@suse.cz>
To: Liu Bo <bo.li.liu@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] Btrfs: add write_flags for compression bio
Date: Mon, 30 Oct 2017 14:33:28 +0100 [thread overview]
Message-ID: <20171030133328.GU3521@twin.jikos.cz> (raw)
In-Reply-To: <20171024051816.8269-1-bo.li.liu@oracle.com>
On Mon, Oct 23, 2017 at 11:18:16PM -0600, Liu Bo wrote:
> Compression code path has only flaged bios with REQ_OP_WRITE no matter
> where the bios come from, but it could be a sync write if fsync starts
> this writeback or a normal writeback write if wb kthread starts a
> periodic writeback.
>
> It breaks the rule that sync writes and writeback writes need to be
> differentiated from each other, because from the POV of block layer,
> all bios need to be recognized by these flags in order to do some
> management, e.g. throttlling.
>
> This passes writeback_control to compression write path so that it can
> send bios with proper flags to block layer.
>
> Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
prev parent reply other threads:[~2017-10-30 13:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 21:10 [PATCH] Btrfs: add write_flags for compression bio Liu Bo
2017-10-16 13:33 ` David Sterba
2017-10-16 17:34 ` Liu Bo
2017-10-24 5:18 ` [PATCH v2] " Liu Bo
2017-10-30 13:33 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171030133328.GU3521@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).