From: David Sterba <dsterba@suse.cz>
To: Filipe Manana <fdmanana@gmail.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs: switch uuid tree semaphore to mutex
Date: Tue, 7 Nov 2017 15:20:12 +0100 [thread overview]
Message-ID: <20171107142012.GA27557@suse.cz> (raw)
In-Reply-To: <CAL3q7H6n8sxOjE8tRBmCMFSjF=F9_B1dNkaGj0FD3UO5=95u+w@mail.gmail.com>
On Tue, Nov 07, 2017 at 01:58:12PM +0000, Filipe Manana wrote:
> On Mon, Nov 6, 2017 at 6:24 PM, David Sterba <dsterba@suse.com> wrote:
> > @@ -3696,9 +3696,9 @@ void close_ctree(struct btrfs_fs_info *fs_info)
> > btrfs_qgroup_wait_for_completion(fs_info, false);
> >
> > /* wait for the uuid_scan task to finish */
> > - down(&fs_info->uuid_tree_rescan_sem);
> > + mutex_lock(&fs_info->uuid_tree_mutex);
> > /* avoid complains from lockdep et al., set sem back to initial state */
>
> This comment should go away too.
Agreed, removed in v2.
next prev parent reply other threads:[~2017-11-07 14:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 18:24 [PATCH] btrfs: switch uuid tree semaphore to mutex David Sterba
2017-11-06 18:49 ` Nikolay Borisov
2017-11-07 13:58 ` Filipe Manana
2017-11-07 14:20 ` David Sterba [this message]
2017-11-22 19:20 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171107142012.GA27557@suse.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).