From: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
To: <dsterba@suse.cz>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 3/3] btrfs-progs: qgroup: cleanup __qgroup_search, no functional change
Date: Fri, 10 Nov 2017 17:57:29 +0800 [thread overview]
Message-ID: <20171110095729.GC30275@fnst.localdomain> (raw)
In-Reply-To: <20171109165148.GO27557@twin.jikos.cz>
On Thu, Nov 09, 2017 at 05:51:48PM +0100, David Sterba wrote:
>On Tue, Oct 31, 2017 at 05:13:45PM +0800, Lu Fengqi wrote:
>> 1. Use goto instead of while (1) to reduce the level of indentation
>
>I'd rather avoid this goto pattern in new code, using while is ok. If
>the indentation depth becomes problem, then the inner code should be
>moved to a helper.
Make sense.
>
>> 2. Replace the if statement with the switch statement
>
>This is good.
>
>> 3. move the BTRFS_IOC_TREE_SEARCH ioctl error handler to __qgroup_search
>
>This one as well, but please make them into separate patches, the code
>is being moved and changed at the same time. This makes the review
>harder.
>
>
Ok, I'll split the patch and resend it later.
--
Thanks,
Lu
next prev parent reply other threads:[~2017-11-10 9:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 9:13 [PATCH 0/3] add_qgroup/update_qgroup/__qgroup_search cleanup Lu Fengqi
2017-10-31 9:13 ` [PATCH 1/3] btrfs-progs: qgroup: cleanup the redundant function add_qgroup Lu Fengqi
2017-10-31 9:13 ` [PATCH 2/3] btrfs-progs: qgroup: split update_qgroup to reduce arguments Lu Fengqi
2017-10-31 9:13 ` [PATCH 3/3] btrfs-progs: qgroup: cleanup __qgroup_search, no functional change Lu Fengqi
2017-11-09 16:51 ` David Sterba
2017-11-10 9:57 ` Lu Fengqi [this message]
2017-11-09 16:55 ` [PATCH 0/3] add_qgroup/update_qgroup/__qgroup_search cleanup David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171110095729.GC30275@fnst.localdomain \
--to=lufq.fnst@cn.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).