From: Marc MERLIN <marc@merlins.org>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Lu Fengqi <lufq.fnst@cn.fujitsu.com>,
Btrfs BTRFS <linux-btrfs@vger.kernel.org>,
David Sterba <dsterba@suse.cz>
Subject: Re: btrfs check: add_missing_dir_index: BUG_ON `ret` triggered, value -17
Date: Sat, 18 Nov 2017 08:34:04 -0800 [thread overview]
Message-ID: <20171118163404.u434t6afi7ghns57@merlins.org> (raw)
In-Reply-To: <46fbd8c2-65f1-b281-7e17-2253f6dc3aa9@gmx.com>
On Sat, Nov 18, 2017 at 08:16:32AM +0800, Qu Wenruo wrote:
> > item 27 key (1919785864 DIR_ITEM 2591417872) itemoff 14637 itemsize 46
> > location key (1919805647 INODE_ITEM 0) type FILE
> > transid 2231988 data_len 0 name_len 16
> > name: 1955-capture.jpg
>
> OK, this DIR_ITEM matches with INODE_REF.
> So btrfs-check should only need to insert DIR_INDEX for it.
> >
> >> Although what we could try is to avoid BUG_ON(), but I'm afraid the
> >> problem is more severe than my expectation.
> >
> > How does it look now?
>
> At least we know what btrfs check should do.
> I could dig it a little deeper to see if we could fix it.
> (Or something strange happened again)
Thanks for having had a look, hopefully it helps improving btrfs check,
thanks for getting the info and getting it turned into better code :)
In the meantime this was an easy FS to just wipe and start over with, so
I just did that.
Marc
--
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
.... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/ | PGP 1024R/763BE901
prev parent reply other threads:[~2017-11-18 16:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 2:26 btrfs check: add_missing_dir_index: BUG_ON `ret` triggered, value -17 Marc MERLIN
2017-11-17 5:17 ` Qu Wenruo
2017-11-17 6:17 ` Marc MERLIN
2017-11-17 7:30 ` Marc MERLIN
2017-11-17 8:12 ` Qu Wenruo
2017-11-17 15:50 ` Marc MERLIN
2017-11-18 0:16 ` Qu Wenruo
2017-11-18 16:34 ` Marc MERLIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171118163404.u434t6afi7ghns57@merlins.org \
--to=marc@merlins.org \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=lufq.fnst@cn.fujitsu.com \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox