From: Su Yue <suy.fnst@cn.fujitsu.com>
To: <linux-btrfs@vger.kernel.org>
Subject: [PATCH 2/3] btrfs-progs: check: do not reset ret after try_repair_inode
Date: Tue, 21 Nov 2017 18:15:23 +0800 [thread overview]
Message-ID: <20171121101524.2014-2-suy.fnst@cn.fujitsu.com> (raw)
In-Reply-To: <20171121101524.2014-1-suy.fnst@cn.fujitsu.com>
After failure of try_repair_inode(), the value @ret will be reseted
anyway. Then counter @error won't be incremented.
So do not reset @ret after try_repair_inode().
Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
---
cmds-check.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/cmds-check.c b/cmds-check.c
index 5c15dfb60b9a..68348ae94c8b 100644
--- a/cmds-check.c
+++ b/cmds-check.c
@@ -3968,7 +3968,6 @@ static int check_inode_recs(struct btrfs_root *root,
free_inode_rec(rec);
continue;
}
- ret = 0;
}
if (!(repair && ret == 0))
--
2.15.0
next prev parent reply other threads:[~2017-11-21 10:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 10:15 [PATCH 1/3] btrfs-progs: check: report more specific info about invalid location Su Yue
2017-11-21 10:15 ` Su Yue [this message]
2018-01-08 19:00 ` [PATCH 2/3] btrfs-progs: check: do not reset ret after try_repair_inode David Sterba
2017-11-21 10:15 ` [PATCH 3/3] btrfs-progs: check: record last checked root_item in original mode Su Yue
2018-01-08 19:03 ` David Sterba
2018-01-09 7:27 ` Su Yue
2017-11-21 11:46 ` [PATCH 1/3] btrfs-progs: check: report more specific info about invalid location Nikolay Borisov
2017-11-22 1:48 ` Su Yue
2017-11-22 2:17 ` [PATCH v2 " Su Yue
2017-11-22 7:06 ` Nikolay Borisov
2018-01-08 19:04 ` David Sterba
2018-01-09 7:52 ` [PATCH 2/3 v2] btrfs-progs: check: do not reset ret after try_repair_inode Su Yue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121101524.2014-2-suy.fnst@cn.fujitsu.com \
--to=suy.fnst@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).