From: David Sterba <dsterba@suse.cz>
To: Edmund Nadolski <enadolski@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/3] btrfs: update some code documentation
Date: Tue, 21 Nov 2017 14:24:40 +0100 [thread overview]
Message-ID: <20171121132440.GH3553@twin.jikos.cz> (raw)
In-Reply-To: <20171120202449.22947-3-enadolski@suse.com>
On Mon, Nov 20, 2017 at 01:24:48PM -0700, Edmund Nadolski wrote:
> +/*
> + * Reserve some special-case values for the extent_map .start, .block_start,
> + *: and .orig_start fields.
I'm used to write the structure members as type::member, which resembles
the C++ syntax. There are already a few recently added examples in the
code documentation, eg. the device mutexes in volume.c. I'd like to
maintain some consistency so that it's clear which syntax we use for
btrfs documentataion. The .member also looks acceptable to me, though
I'd prefer the :: way.
next prev parent reply other threads:[~2017-11-21 13:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 20:24 [PATCH 0/3] btrfs: some code cleanup and documentation Edmund Nadolski
2017-11-20 20:24 ` [PATCH 1/3] btrfs: btrfs_inode_log_parent should use defined inode_only values Edmund Nadolski
2017-11-21 8:44 ` Nikolay Borisov
2017-11-20 20:24 ` [PATCH 2/3] btrfs: update some code documentation Edmund Nadolski
2017-11-21 7:59 ` Nikolay Borisov
2017-11-21 22:20 ` Edmund Nadolski
2017-11-22 7:01 ` Nikolay Borisov
2017-11-21 13:24 ` David Sterba [this message]
2017-11-20 20:24 ` [PATCH 3/3] btrfs: remove dead code from btrfs_get_extent Edmund Nadolski
2017-11-21 8:25 ` Nikolay Borisov
2017-11-21 13:28 ` [PATCH 0/3] btrfs: some code cleanup and documentation David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121132440.GH3553@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=enadolski@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).