From: David Sterba <dsterba@suse.cz>
To: Su Yue <suy.fnst@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: Re: [PATCH v2 1/3] btrfs-progs: fi defrag: clean up duplicate code if find errors
Date: Tue, 28 Nov 2017 17:07:11 +0100 [thread overview]
Message-ID: <20171128160711.GW3553@twin.jikos.cz> (raw)
In-Reply-To: <20171128091450.21789-1-suy.fnst@cn.fujitsu.com>
On Tue, Nov 28, 2017 at 05:14:48PM +0800, Su Yue wrote:
> In function cmd_filesystem_defrag(), lines of code for error handling
> are duplicate and hard to expand in further.
>
> Create a jump label for errors.
>
> Signed-off-by: Su Yue <suy.fnst@cn.fujitsu.com>
Applied, thanks.
next prev parent reply other threads:[~2017-11-28 16:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 9:14 [PATCH v2 1/3] btrfs-progs: fi defrag: clean up duplicate code if find errors Su Yue
2017-11-28 9:14 ` [PATCH v2 2/3] btrfs-progs: fi defrag: do not exit if defrag range ioctl is unsupported Su Yue
2017-11-28 15:57 ` David Sterba
2017-11-28 9:14 ` [PATCH v2 3/3] btrfs-progs: fi defrag: extend -c to drop nocompress flag on files Su Yue
2017-11-28 16:07 ` David Sterba
2017-11-29 1:54 ` Su Yue
2017-11-30 18:30 ` David Sterba
2017-11-28 16:07 ` David Sterba [this message]
2017-11-29 2:12 ` [PATCH v3 2/3] btrfs-progs: fi defrag: do not exit if defrag range ioctl is unsupported Su Yue
2017-11-30 6:37 ` Qu Wenruo
2017-11-30 6:49 ` Qu Wenruo
2017-11-30 6:47 ` [PATCH v2 1/3] btrfs-progs: fi defrag: clean up duplicate code if find errors Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128160711.GW3553@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=suy.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).