From: David Sterba <dsterba@suse.cz>
To: Colin King <colin.king@canonical.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: make function update_share_count static
Date: Thu, 30 Nov 2017 16:50:54 +0100 [thread overview]
Message-ID: <20171130155054.GL3553@twin.jikos.cz> (raw)
In-Reply-To: <20171130121447.5118-1-colin.king@canonical.com>
On Thu, Nov 30, 2017 at 12:14:47PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function update_share_count is local to the source and does
> not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> fs/btrfs/backref.c:219:6: warning: symbol 'update_share_count' was not
> declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: David Sterba <dsterba@suse.com>
prev parent reply other threads:[~2017-11-30 15:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 12:14 [PATCH] btrfs: make function update_share_count static Colin King
2017-11-30 15:50 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130155054.GL3553@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=colin.king@canonical.com \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).