From: David Sterba <dsterba@suse.cz>
To: Chris Mason <clm@fb.com>
Cc: Tejun Heo <tj@kernel.org>, Jan Kara <jack@suse.cz>,
axboe@kernel.dk, jbacik@fb.com, kernel-team@fb.com,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [PATCHSET v2] cgroup, writeback, btrfs: make sure btrfs issues metadata IOs from the root cgroup
Date: Thu, 30 Nov 2017 18:23:16 +0100 [thread overview]
Message-ID: <20171130172316.GM3553@twin.jikos.cz> (raw)
In-Reply-To: <fff25924-f632-8a6c-9e48-765971b09cca@fb.com>
On Wed, Nov 29, 2017 at 01:38:26PM -0500, Chris Mason wrote:
> On 11/29/2017 12:05 PM, Tejun Heo wrote:
> > On Wed, Nov 29, 2017 at 09:03:30AM -0800, Tejun Heo wrote:
> >> Hello,
> >>
> >> On Wed, Nov 29, 2017 at 05:56:08PM +0100, Jan Kara wrote:
> >>> What has happened with this patch set?
> >>
> >> No idea. cc'ing Chris directly. Chris, if the patchset looks good,
> >> can you please route them through the btrfs tree?
> >
> > lol looking at the patchset again, I'm not sure that's obviously the
> > right tree. It can either be cgroup, block or btrfs. If no one
> > objects, I'll just route them through cgroup.
>
> We'll have to coordinate a bit during the next merge window but I don't
> have a problem with these going in through cgroup. Dave does this sound
> good to you?
There are only minor changes to btrfs code so cgroup tree would be
better.
> I'd like to include my patch to do all crcs inline (instead of handing
> off to helper threads) when io controls are in place. By the merge
> window we should have some good data on how much it's all helping.
Are there any problems in sight if the inline crc and cgroup chnanges go
separately? I assume there's a runtime dependency, not a code
dependency, so it could be sorted by the right merge order.
next prev parent reply other threads:[~2017-11-30 17:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 15:54 [PATCHSET v2] cgroup, writeback, btrfs: make sure btrfs issues metadata IOs from the root cgroup Tejun Heo
2017-10-10 15:54 ` [PATCH 1/5] blkcg: export blkcg_root_css Tejun Heo
2017-10-11 7:50 ` Jan Kara
2017-10-10 15:54 ` [PATCH 2/5] cgroup, writeback: replace SB_I_CGROUPWB with per-inode S_CGROUPWB Tejun Heo
2017-10-10 15:54 ` [PATCH 3/5] buffer_head: separate out create_bh_bio() from submit_bh_wbc() Tejun Heo
2017-10-11 7:54 ` Jan Kara
2017-10-10 15:54 ` [PATCH 4/5] cgroup, buffer_head: implement submit_bh_blkcg_css() Tejun Heo
2017-10-11 7:55 ` Jan Kara
2017-10-10 15:54 ` [PATCH 5/5] btrfs: ensure that metadata and flush are issued from the root cgroup Tejun Heo
2017-10-10 16:43 ` [PATCH v2 " Tejun Heo
2017-10-10 17:45 ` Liu Bo
2017-10-11 17:07 ` David Sterba
2017-10-12 15:38 ` Tejun Heo
2017-10-12 17:06 ` [PATCH v3 " Tejun Heo
2017-10-12 18:56 ` David Sterba
2017-11-29 16:56 ` [PATCHSET v2] cgroup, writeback, btrfs: make sure btrfs issues metadata IOs " Jan Kara
2017-11-29 17:03 ` Tejun Heo
2017-11-29 17:05 ` Tejun Heo
2017-11-29 18:38 ` Chris Mason
2017-11-30 17:23 ` David Sterba [this message]
2017-11-30 17:34 ` Chris Mason
2017-12-01 10:52 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130172316.GM3553@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=axboe@kernel.dk \
--cc=clm@fb.com \
--cc=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).