From: Anand Jain <anand.jain@oracle.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v4] btrfs-progs: add 'btrfs device ignore' cli
Date: Tue, 5 Dec 2017 16:52:57 +0800 [thread overview]
Message-ID: <20171205085258.4038-3-anand.jain@oracle.com> (raw)
In-Reply-To: <20171205085258.4038-1-anand.jain@oracle.com>
This patch adds
btrfs device ignode <dev>
so that a device can be ignored/missed during mount if the device is
already been scanned. Basically, this command will undo the effect
of the command
btrfs device scan <dev>
This change is compatible with older kernel without the ioctl
BTRFS_IOC_IGNORE_DEV which is added here. At which it shall
report 'Inappropriate ioctl for device'. And will report
'Operation not permitted' on mounted device.
Signed-off-by: Anand Jain <anand.jain@oracle.com>
---
v1-4: No change.
cmds-device.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
ioctl.h | 2 ++
2 files changed, 56 insertions(+)
diff --git a/cmds-device.c b/cmds-device.c
index f4cdb39f64ac..31b1945d3339 100644
--- a/cmds-device.c
+++ b/cmds-device.c
@@ -329,6 +329,59 @@ out:
return !!ret;
}
+static const char * const cmd_device_ignore_usage[] = {
+ "btrfs device ignore [<device>]",
+ "Ignore a device in the btrfs kernel module.",
+ NULL
+};
+
+static int btrfs_ignore_one_device(char *path)
+{
+ struct btrfs_ioctl_vol_args args;
+ int fd;
+ int ret;
+
+ fd = open("/dev/btrfs-control", O_RDWR);
+ if (fd < 0)
+ return -errno;
+
+ memset(&args, 0, sizeof(args));
+ strncpy_null(args.name, path);
+ ret = ioctl(fd, BTRFS_IOC_IGNORE_DEV, &args);
+ if (ret)
+ ret = -errno;
+ close(fd);
+ return ret;
+}
+
+static int cmd_device_ignore(int argc, char **argv)
+{
+ int ret = 0;
+ char *path;
+
+ if (check_argc_max(argc - optind, 1))
+ usage(cmd_device_ignore_usage);
+
+ if (is_block_device(argv[1]) != 1) {
+ error("Not a block device: %s", argv[1]);
+ return -ENOENT;
+ }
+
+ path = canonicalize_path(argv[1]);
+ if (!path) {
+ error("Could not canonicalize path '%s': %s",
+ argv[1], strerror(errno));
+ return -ENOENT;
+ }
+
+ ret = btrfs_ignore_one_device(path);
+ if (ret)
+ error("Can't ignore %s: %s", path, strerror(-ret));
+
+ free(path);
+ return ret;
+}
+
static const char * const cmd_device_ready_usage[] = {
"btrfs device ready <device>",
"Check device to see if it has all of its devices in cache for mounting",
@@ -604,6 +657,7 @@ const struct cmd_group device_cmd_group = {
CMD_ALIAS },
{ "remove", cmd_device_remove, cmd_device_remove_usage, NULL, 0 },
{ "scan", cmd_device_scan, cmd_device_scan_usage, NULL, 0 },
+ { "ignore", cmd_device_ignore, cmd_device_ignore_usage, NULL, 0 },
{ "ready", cmd_device_ready, cmd_device_ready_usage, NULL, 0 },
{ "stats", cmd_device_stats, cmd_device_stats_usage, NULL, 0 },
{ "usage", cmd_device_usage,
diff --git a/ioctl.h b/ioctl.h
index 709e996f401c..bef8508119aa 100644
--- a/ioctl.h
+++ b/ioctl.h
@@ -721,6 +721,8 @@ static inline char *btrfs_err_str(enum btrfs_err_code err_code)
struct btrfs_ioctl_vol_args)
#define BTRFS_IOC_SCAN_DEV _IOW(BTRFS_IOCTL_MAGIC, 4, \
struct btrfs_ioctl_vol_args)
+#define BTRFS_IOC_IGNORE_DEV _IOW(BTRFS_IOCTL_MAGIC, 5, \
+ struct btrfs_ioctl_vol_args)
/* trans start and trans end are dangerous, and only for
* use by applications that know how to avoid the
* resulting deadlocks
--
2.7.0
next prev parent reply other threads:[~2017-12-05 8:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 8:52 [PATCH v4 0/2] Add cli and ioctl to ignore a scanned device Anand Jain
2017-12-05 8:52 ` [PATCH v4 1/2] btrfs: add function to device list delete Anand Jain
2017-12-05 19:06 ` David Sterba
2017-12-05 21:30 ` Anand Jain
2017-12-05 8:52 ` Anand Jain [this message]
2017-12-05 19:11 ` [PATCH v4] btrfs-progs: add 'btrfs device ignore' cli David Sterba
2017-12-06 7:26 ` Anand Jain
2017-12-05 8:52 ` [PATCH v4 2/2] btrfs: introduce feature to ignore a btrfs device Anand Jain
2017-12-05 19:24 ` David Sterba
2017-12-06 7:55 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205085258.4038-3-anand.jain@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).