From: David Sterba <dsterba@suse.cz>
To: Gu Jinxiang <gujx@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: use enum instead of constant value
Date: Tue, 5 Dec 2017 18:35:46 +0100 [thread overview]
Message-ID: <20171205173546.GL3553@twin.jikos.cz> (raw)
In-Reply-To: <1512470130-7240-1-git-send-email-gujx@cn.fujitsu.com>
On Tue, Dec 05, 2017 at 06:35:30PM +0800, Gu Jinxiang wrote:
> Use enum READA_BACK instead of value 1 to keep source robust.
Are you sure that READA_BACK is the right one? It corresponds to the
value 1, but the actual readahead direction semantics should be
considered. It is not obvious and needs some explanation in the changelog.
next prev parent reply other threads:[~2017-12-05 17:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 10:35 [PATCH] btrfs: use enum instead of constant value Gu Jinxiang
2017-12-05 17:35 ` David Sterba [this message]
2018-01-11 6:59 ` [PATCH v2] " Gu Jinxiang
2018-01-11 7:24 ` Nikolay Borisov
2018-01-11 8:12 ` [PATCH v3 1/2] " Gu Jinxiang
2018-01-11 8:12 ` [PATCH v3 2/2] " Gu Jinxiang
2018-01-11 8:14 ` Nikolay Borisov
2018-01-11 8:14 ` [PATCH v3 1/2] " Nikolay Borisov
2018-02-06 14:54 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205173546.GL3553@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=gujx@cn.fujitsu.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).